Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix: static getters / setters can have incorrect this binding #4328

Closed

Conversation

matthewjh
Copy link

Please see #4327.

There's a modification to the __extends helper that fixes this issue, however I'm unsure how to write tests for this.

I've tried to add a compiler test case to cover this, but it's hard to see how I can use it to check that this's runtime type is correct.

@msftclas
Copy link

Hi @matthewjh, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Aug 17, 2015

Please see #4327 for more discussion on this topic.

@mhegazy mhegazy closed this Aug 17, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants