Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most package names for filename-based ATA #40678

Closed
wants to merge 1 commit into from

Conversation

jessetrinity
Copy link
Contributor

@jessetrinity jessetrinity commented Sep 21, 2020

Fixes #40123

This greatly reduces the number of different typings packages available to ATA triggered when a .js file is discovered in a VS project or when the file is opened in VS Code.

The rules I used for retaining types are as follows

  • The package was in top 20 @types packages on npm.
  • The package was in the top 20 downloaded typings for VS users.
  • Retain the regex matched packages which we presumably care enough about to go into detail.

20 is a somewhat arbitrary number based on when the number of installs by package levels out at an order of magnitude lower than the most popular package in VS (jquery).

The original issue also mentions adding a status message for typings installed events. VS Code already does this and I have a PR open in the TypeScript-VS repo to add the message there.

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Sep 21, 2020
@jessetrinity
Copy link
Contributor Author

cc @mjbvz for VS Code awareness/input

@mjbvz
Copy link
Contributor

mjbvz commented Sep 21, 2020

Change makes sense to me.

If this issue does have an impact, I expect it will mainly effect newer users and would be reported as "IntelliSense stopped working". I'll keep an eye out for those in insiders and after release (unfortunately newer users are much less likely be insiders too)

@jessetrinity
Copy link
Contributor Author

After much discussion we have decided that limiting the type names is not the way to go. If we do anything, we should make this behavior configurable separately from typeAcquisition: enable/disable.

@jessetrinity jessetrinity deleted the fix40123 branch October 5, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic Type Acquisition based on filename matching pulls in too many irrelevant typings
3 participants