Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(36416): ERR <semantic> TypeScript Server Error #36751

Merged
merged 1 commit into from
Feb 12, 2020
Merged

fix(36416): ERR <semantic> TypeScript Server Error #36751

merged 1 commit into from
Feb 12, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #36416

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.8

@typescript-bot typescript-bot mentioned this pull request Feb 12, 2020
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #36757 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 12, 2020
@a-tarasyuk @typescript-bot
Cherry-pick PR microsoft#36751 into release-3.8
f8fa34e 
Component commits:
ebbba5b fix(36416): empty import path causes server crash
@sandersn
Copy link
Member

@sheetalkamat @DanielRosenwasser sounds like this should be merged into master too, right?

@DanielRosenwasser
Copy link
Member

Probably

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 12, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at ebbba5b. You can monitor the build here. It should now contribute to this PR's status checks.

@sandersn sandersn merged commit e435054 into microsoft:master Feb 12, 2020
@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 12, 2020 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/64373/artifacts?artifactName=tgz&fileId=073ABBABB2E72CD11FD2D0377C5B99B901E7E9A7E680D626B5FC4E212CDFBAF502&fileName=/typescript-3.9.0-insiders.20200212.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

DanielRosenwasser pushed a commit that referenced this pull request Feb 12, 2020
@a-tarasyuk
🤖 Cherry-pick PR #36751 into release-3.8 (#36757)
1986a5f 
Component commits:
ebbba5b fix(36416): empty import path causes server crash

Co-authored-by: Alexander T. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERR <semantic> TypeScript Server Error (3.7.5)
5 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot @sandersn @sheetalkamat