Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert with declaration emit for export specifier for a global #3641

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jun 26, 2015

Fixes #3640

@mprobst
Copy link
Contributor

mprobst commented Jun 26, 2015

This fixes the assertion error that I have seen. I'm getting a bunch of new errors on Angular, but I think those are because of the more precise type checking, now that our Promise doesn't end up being effectively any anymore.

So cannot confirm 100% success yet, but this looks good.

@JsonFreeman
Copy link
Contributor

👍

mhegazy added a commit that referenced this pull request Jun 30, 2015
Fix assert with declaration emit for export specifier for a global
@mhegazy mhegazy merged commit fe46122 into master Jun 30, 2015
@mhegazy mhegazy deleted the exportSepcifierInDeclarations branch June 30, 2015 00:28
weswigham added a commit to weswigham/TypeScript that referenced this pull request Nov 8, 2017
weswigham added a commit that referenced this pull request Nov 9, 2017
* Badness

* Revert #3641, whose original bug has been fixed by other means

* Add another repro
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants