Fix #2929: relax the check for export= in ES6 if it is resulting from an ambient declaration #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an ambient declaration
|
got verbal sign off from @vladima |
mhegazy
added a commit
that referenced
this pull request
Apr 30, 2015
Fix #2929: relax the check for export= in ES6 if it is resulting from an ambient declaration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export =is an error in ES6 and system module outputs as there is no way to emit it correctly. There is no reason why to make this an error for ambient declarations though.The change allows the use of export= in ambient declarations.