Slight improvement to SymbolDisplay for 'module.exports =' #25013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
mhegazy
reviewed
Jun 19, 2018
| @@ -21,7 +21,7 @@ const [r0, r1, r2, r3, r4, r5] = test.ranges(); | |||
| verify.referenceGroups(r0, [ | |||
| { definition: "(local class) C", ranges: [r0] }, | |||
| // TODO: This definition is really ugly | |||
| { definition: "(alias) (local class) export=\nimport export=", ranges: [r3] }, | |||
| { definition: "(alias) (local class) C\nexport = export=", ranges: [r3] }, | |||
There was a problem hiding this comment.
not sure this looks any better than the previous one..
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24025
Makes us treat
module.exports =more likeexport =in symbolDisplay. Unfortunately,addFullSymbolName()adds a secondexport =because that's the name we get from the checker -- ideally we could fix the checker to return the name of the exported class like it does forexport =.