Skip qualification check when symbol is already in the process of being qualified #21337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocess of being qualified
weswigham
force-pushed
the
crazy-name-dependent-behavior
branch
from
08978ba to
2b52fbd
Compare
sandersn
reviewed
Jan 23, 2018
| @@ -2424,12 +2424,15 @@ namespace ts { | |||
| const visitedSymbolTables: SymbolTable[] = []; | |||
| return forEachSymbolTableInScope(enclosingDeclaration, getAccessibleSymbolChainFromSymbolTable); | |||
|
|
|||
| function getAccessibleSymbolChainFromSymbolTable(symbols: SymbolTable): Symbol[] | undefined { | |||
| /** | |||
| * @param {ignoreQualification} boolean Set when a symbol is being looked for through the exports of another symbol (meaning we have a route to qualify it already) | |||
There was a problem hiding this comment.
How many calls are there to this function? Would it be horrible to make the new parameter required?
There was a problem hiding this comment.
It must remain optional because it's usage other than the direct call where it is set is in the callback position for forEachSymbolTableInScope. We want to pass false there anyway, so we keep is optional to avoid changing forEachSymbolTableInScope or creating another closure.
mhegazy
approved these changes
Jan 24, 2018
|
@weswigham please port this change to release-2.7 as well. |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Jan 24, 2018
…ocess of being qualified (microsoft#21337)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21313
This is needed because 1. we were doing work we didn't need to do (if the symbol was found via the exports of an accessible symbol, it is accessible via it), and 2. unconditionally doing so fails when symbols are present in multiple containers (since symbol.parent only points at the original container, which can be inaccessible even if the symbol is accessible via another container).