[Master] fix 15463 #15595
Merged
[Master] fix 15463 #15595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 4, 2017 14:39
…icitly specified attributes are correct
mhegazy
reviewed
May 5, 2017
src/compiler/checker.ts
Outdated
| @@ -13351,7 +13356,8 @@ namespace ts { | |||
| */ | |||
| function createJsxAttributesType(symbol: Symbol, attributesTable: Map<Symbol>) { | |||
| const result = createAnonymousType(symbol, attributesTable, emptyArray, emptyArray, /*stringIndexInfo*/ undefined, /*numberIndexInfo*/ undefined); | |||
| const freshObjectLiteralFlag = compilerOptions.suppressExcessPropertyErrors ? 0 : TypeFlags.FreshLiteral; | |||
| // Spread object doesn't have freshness flag to allow excess attributes as it is very common for parent component to spread its "props" to other components in its render method. | |||
| const freshObjectLiteralFlag = spread !== emptyObjectType || compilerOptions.suppressExcessPropertyErrors ? 0 : TypeFlags.FreshLiteral; | |||
There was a problem hiding this comment.
so why do we have this flag, should not the check below catch all the cases?
There was a problem hiding this comment.
yes but I don't think we should do for all explicitly defined. since that case you should cover by type assignability check
There was a problem hiding this comment.
talk offline with @mhegazy it is being too clever and doing second pass isn't expensive so we should remove this flag and always check for that explicit property has correct name
mhegazy
reviewed
May 5, 2017
src/compiler/checker.ts
Outdated
| if (sourceAttributesType !== anyType && !(sourceAttributesType.flags & TypeFlags.FreshLiteral)) { | ||
| for (const attribute of openingLikeElement.attributes.properties) { | ||
| if (isJsxAttribute(attribute) && !getPropertyOfType(targetAttributesType, attribute.name.text)) { | ||
| error(attribute, Diagnostics.Property_0_does_not_exist_on_type_1, attribute.name.text, typeToString(targetAttributesType)); |
There was a problem hiding this comment.
i would break after the first error to avoid cascading errors.
added 6 commits
May 4, 2017 22:16
mhegazy
approved these changes
May 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15463 We are now checking attributes according to:
Only contain explicitly attributes -> no excess properties allowed
Contain spread attributes (even with explicit attributes) -> 1. check type assignability (allow access properties) 2. for each explicit attributes check if the attribute name match the target name.
we only report that "children" will get overwritten if it is explicitly specified in the attributes and the element contains JSX.children