-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Produce an error for an augmentation of an untyped module even if moduleNotFoundError
is not defined
#12852
Merged
Merged
Produce an error for an augmentation of an untyped module even if moduleNotFoundError
is not defined
#12852
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
tests/baselines/reference/untypedModuleImport_withAugmentation2.errors.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/node_modules/augmenter/index.d.ts(3,16): error TS2665: Invalid module name in augmentation. Module 'js' resolves to an untyped module at '/node_modules/js/index.js', which cannot be augmented. | ||
|
||
|
||
==== /a.ts (0 errors) ==== | ||
import { } from "augmenter"; | ||
|
||
==== /node_modules/augmenter/index.d.ts (1 errors) ==== | ||
// This tests that augmenting an untyped module is forbidden even in an ambient context. Contrast with `moduleAugmentationInDependency.ts`. | ||
|
||
declare module "js" { | ||
~~~~ | ||
!!! error TS2665: Invalid module name in augmentation. Module 'js' resolves to an untyped module at '/node_modules/js/index.js', which cannot be augmented. | ||
export const j: number; | ||
} | ||
export {}; | ||
|
||
==== /node_modules/js/index.js (0 errors) ==== | ||
This file is not processed. | ||
|
19 changes: 19 additions & 0 deletions
19
tests/baselines/reference/untypedModuleImport_withAugmentation2.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
//// [tests/cases/compiler/untypedModuleImport_withAugmentation2.ts] //// | ||
|
||
//// [index.d.ts] | ||
// This tests that augmenting an untyped module is forbidden even in an ambient context. Contrast with `moduleAugmentationInDependency.ts`. | ||
|
||
declare module "js" { | ||
export const j: number; | ||
} | ||
export {}; | ||
|
||
//// [index.js] | ||
This file is not processed. | ||
|
||
//// [a.ts] | ||
import { } from "augmenter"; | ||
|
||
|
||
//// [a.js] | ||
"use strict"; |
14 changes: 14 additions & 0 deletions
14
tests/cases/compiler/untypedModuleImport_withAugmentation2.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// @noImplicitReferences: true | ||
// This tests that augmenting an untyped module is forbidden even in an ambient context. Contrast with `moduleAugmentationInDependency.ts`. | ||
|
||
// @Filename: /node_modules/augmenter/index.d.ts | ||
declare module "js" { | ||
export const j: number; | ||
} | ||
export {}; | ||
|
||
// @Filename: /node_modules/js/index.js | ||
This file is not processed. | ||
|
||
// @Filename: /a.ts | ||
import { } from "augmenter"; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has no effect on tests, but seemed more correct, as
moduleName
is escaped, and the below error also usesmoduleReference
.