Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce an error for an augmentation of an untyped module even if moduleNotFoundError is not defined #12852

Merged
1 commit merged into from
Dec 12, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1439,9 +1439,8 @@ namespace ts {
// May be an untyped module. If so, ignore resolutionDiagnostic.
if (!isRelative && resolvedModule && !extensionIsTypeScript(resolvedModule.extension)) {
if (isForAugmentation) {
Debug.assert(!!moduleNotFoundError);
const diag = Diagnostics.Invalid_module_name_in_augmentation_Module_0_resolves_to_an_untyped_module_at_1_which_cannot_be_augmented;
error(errorNode, diag, moduleName, resolvedModule.resolvedFileName);
error(errorNode, diag, moduleReference, resolvedModule.resolvedFileName);
Copy link
Author

@ghost ghost Dec 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has no effect on tests, but seemed more correct, as moduleName is escaped, and the below error also uses moduleReference.

}
else if (compilerOptions.noImplicitAny && moduleNotFoundError) {
error(errorNode,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/node_modules/augmenter/index.d.ts(3,16): error TS2665: Invalid module name in augmentation. Module 'js' resolves to an untyped module at '/node_modules/js/index.js', which cannot be augmented.


==== /a.ts (0 errors) ====
import { } from "augmenter";

==== /node_modules/augmenter/index.d.ts (1 errors) ====
// This tests that augmenting an untyped module is forbidden even in an ambient context. Contrast with `moduleAugmentationInDependency.ts`.

declare module "js" {
~~~~
!!! error TS2665: Invalid module name in augmentation. Module 'js' resolves to an untyped module at '/node_modules/js/index.js', which cannot be augmented.
export const j: number;
}
export {};

==== /node_modules/js/index.js (0 errors) ====
This file is not processed.

19 changes: 19 additions & 0 deletions tests/baselines/reference/untypedModuleImport_withAugmentation2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//// [tests/cases/compiler/untypedModuleImport_withAugmentation2.ts] ////

//// [index.d.ts]
// This tests that augmenting an untyped module is forbidden even in an ambient context. Contrast with `moduleAugmentationInDependency.ts`.

declare module "js" {
export const j: number;
}
export {};

//// [index.js]
This file is not processed.

//// [a.ts]
import { } from "augmenter";


//// [a.js]
"use strict";
14 changes: 14 additions & 0 deletions tests/cases/compiler/untypedModuleImport_withAugmentation2.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// @noImplicitReferences: true
// This tests that augmenting an untyped module is forbidden even in an ambient context. Contrast with `moduleAugmentationInDependency.ts`.

// @Filename: /node_modules/augmenter/index.d.ts
declare module "js" {
export const j: number;
}
export {};

// @Filename: /node_modules/js/index.js
This file is not processed.

// @Filename: /a.ts
import { } from "augmenter";