Improve propagation of modifiers in mapped types #12826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we more consistently propagate property modifiers in mapped types. For a given type parameter
T
, mapped types declared as{ [P in keyof T]: X }
or{ [P in K]: X}
, whereK
is a type parameterK extends keyof T
, now propagate property modifiers fromT
. This in particular means that the predefined typePick<T, K>
now propagates property modifiers fromT
.The intuitive way to think of this is that when a mapped type is known to operate on property names from a particular type (i.e.
T
inkeyof T
) or a subset of the property names of a particular type, then we propagate the property modifiers from that type.Note that because
Pick<T, K>
now propagates modifiers, it can no longer be used to "strip" modifiers.Fixes #12793.