Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use XDG base directory compatible cache location #12676

Merged
merged 2 commits into from
Dec 5, 2016
Merged

use XDG base directory compatible cache location #12676

merged 2 commits into from
Dec 5, 2016

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Dec 5, 2016

fixes #12674

@mhegazy
Copy link
Contributor

mhegazy commented Dec 5, 2016

@Tyriar and @mjbvz any more comments?

@mhegazy
Copy link
Contributor

mhegazy commented Dec 5, 2016

//CC: @billti

Tyriar
Tyriar approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the quick turn around!

@vladima vladima merged commit 225d6d6 into master Dec 5, 2016
@vladima vladima deleted the vladima/12674 branch December 5, 2016 21:40
@mjbvz
Copy link
Contributor

mjbvz commented Dec 7, 2016

@vladima Is this targeting 2.2 or will it make it into 2.1?

@vladima
Copy link
Contributor Author

vladima commented Dec 7, 2016

current plan is that it will go into 2.2

@mjbvz
Copy link
Contributor

mjbvz commented Dec 7, 2016

Ok. At least users can work around this by installing an nightly TS 2.2 build.

We'll keep the bug open on the VSCode side until we pick up a TS build with the fix.

Thanks

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ATA puts types in $HOME/Microsoft
5 participants
@vladima @mhegazy @mjbvz @Tyriar @msftclas