Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node6 to ci #12591

Merged
merged 2 commits into from
Dec 12, 2016
Merged

Add node6 to ci #12591

merged 2 commits into from
Dec 12, 2016

Conversation

chicoxyzzy
Copy link
Contributor

  • Add Node.js 6 LTS to CI
  • Drop unmaintained versions of Node.js from package.json

@msftclas
Copy link

Hi @chicoxyzzy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@RyanCavanaugh
Copy link
Member

@dotnet-bot test ci please

@chicoxyzzy
Copy link
Contributor Author

chicoxyzzy commented Nov 30, 2016

Is it ok that there are no running tests for Node 6 on .NET CI?

@RyanCavanaugh
Copy link
Member

@dotnet-bot test this please

@RyanCavanaugh
Copy link
Member

The jobs have to be manually enabled after they're created - figuring out how to get that rolling here. Is there an issue tracking this PR?

@chicoxyzzy
Copy link
Contributor Author

I didn't find any.

Also I've singed CLA. Should I call some bot to check it?

@msftgits
Copy link

msftgits commented Dec 2, 2016

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Dec 2, 2016
@msftgits msftgits reopened this Dec 2, 2016
@msftclas
Copy link

msftclas commented Dec 2, 2016

Hi @chicoxyzzy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@mhegazy mhegazy merged commit 23ec976 into microsoft:master Dec 12, 2016
@mhegazy mhegazy mentioned this pull request Dec 12, 2016
@chicoxyzzy chicoxyzzy deleted the add_node6_to_ci branch December 13, 2016 19:15
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants