Jsdoc @template issue in syntactic classifier

[basarat]

Consider the following:

/**
 * @template T
 */
function ident<T>(x:T):T {
    return ident;
}

getEncodedSyntacticClassifications will fail with Cannot read property 'text' of undefined

Stack:

NodeObject.createChildren   @   ntypescript.js:50808
NodeObject.getChildren  @   ntypescript.js:50845
processJSDocTemplateTag @   ntypescript.js:56304
classifyJSDocComment    @   ntypescript.js:56270
classifyComment @   ntypescript.js:56243
classifyLeadingTriviaAndGetTokenStart   @   ntypescript.js:56213
tryClassifyNode @   ntypescript.js:56345
processElement  @   ntypescript.js:56482
processElement  @   ntypescript.js:56484
processElement  @   ntypescript.js:56484
getEncodedSyntacticClassifications  @   ntypescript.js:56185

Reason: sourceFile is undefined somewhere in the stack

Version : latest as of this morning

refs alm-tools/alm#82 🌹

[basarat]

Didn't want to pollute the issue with my potentially wrong analysis. This screenshot might help people figure out the fix

getChildren calls createChildren (both without the optional sourceFile) and since parent is not there it crashes .... I haven't taken a deeper look 🌹

[mhegazy]

@zhengbli was looking into a similar issue the other day.

[zhengbli]

@basarat can you give #8702 a try? Thanks!

[mhegazy]

@basarat can you give #8103 a try instead?

[basarat]

I just made a new ntypescript build https://github.com/TypeStrong/ntypescript that has that PR https://github.com/Microsoft/TypeScript/tree/166f399d176486a1247c54dcd6ad4a18e33c18f3 but still no dice:

Thanks for pinging / attempting 🌹

[basarat]

I'm also getting a weird error in the latest build where a property is defined (e.g. styles below) but this.styles is showing an error.

But haven't been able to come up with a short repro ... so you can ignore that for now 🌹

[zhengbli]

It turns out when calling parseIsolatedJSDocComment, the fixing node's parent pointer part was skipped. This should be fixed by #8930, also added a test just for sure.

[basarat]

Verified. Thanks 💯 🌹