-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.d.ts emit drops JSDoc when generating overload signatures from JSDoc @overload
#53350
Comments
This is checked-in to source control include manual revisions documenting overloaded functions, due to a suspected upstream bug in TypeScript. See: microsoft/TypeScript#53350
Just letting you know, you swapped the expected and actual behavior (but not the corresponding screenshots, oddly). |
Thanks! I updated the original text. |
This is checked-in to source control include manual revisions documenting overloaded functions, due to a suspected upstream bug in TypeScript. See: microsoft/TypeScript#53350
* feat: enhance types * docs: fix JSDoc parameter alignment * chore: upgrade to TS 5.0 * fix: generic parameters * fix: all type errors * chore: fix indentation of comments * chore: collapse comments * fix: remove .ts file * Check-in type declaration file This is checked-in to source control include manual revisions documenting overloaded functions, due to a suspected upstream bug in TypeScript. See: microsoft/TypeScript#53350 * Remove extra param tags * feat: add typescript * refactor: convert get-path to typescript * feat: enhance types add TypeScript * chore: upgrade to TS 5.0 * fix: generic parameters * chore: collapse comments * Check-in type declaration file This is checked-in to source control include manual revisions documenting overloaded functions, due to a suspected upstream bug in TypeScript. See: microsoft/TypeScript#53350 * feat: convert to TypeScript * fix: apply @aduth's suggestions * chore: remove unnecessary type assertion * chore: apply @aduth's review suggestions --------- Co-authored-by: Andrew Duthie <[email protected]>
@overload
directive drops function description comments in type declaration@overload
This is most likely because [1] In the example, there are 3 separate jsdoc comments before |
Bug Report
π Search Terms
overload
jsdoc
π Version & Regression Information
5.0.2
β― Playground Link
Broken JavaScript/JSDoc version (see missing comment documentation in
.d.ts
output):For comparison, see working TypeScript version (see included comment documentation in
.d.ts
output):This snippet of code was adapted from the announcement post description.
π» Code
π Actual behavior
There are no docblock comments in generated
.d.ts
.Screenshot from broken JavaScript/JSDoc code snippet:
π Expected behavior
Generated
.d.ts
includes docblock comment descriptions for function, parameters, and return value of overloaded forms.Screenshot from working TypeScript playground link above:
The text was updated successfully, but these errors were encountered: