Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Releasable Package Drop is Failing for release-4.0 #40692

Closed
DanielRosenwasser opened this issue Sep 22, 2020 · 1 comment
Closed

Create Releasable Package Drop is Failing for release-4.0 #40692

DanielRosenwasser opened this issue Sep 22, 2020 · 1 comment
Assignees
@amcasey
Labels
Fix Available A PR has been opened for this issue Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Milestone
TypeScript 4.0.5

Comments

@DanielRosenwasser
Copy link
Member

https://github.com/microsoft/TypeScript/actions?query=workflow%3A%22Create+Releasable+Package+Drop%22

npm ERR! code ENOSELF
npm ERR! Refusing to install package with name "typescript" under a package
npm ERR! also called "typescript". Did you name your project the same
npm ERR! as the dependency you're installing?
npm ERR!

First failure starts here, though it's not clear why.
@DanielRosenwasser DanielRosenwasser added the Infrastructure Issue relates to TypeScript team infrastructure label Sep 22, 2020
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.0.4 milestone Sep 22, 2020
@amcasey amcasey assigned amcasey and unassigned weswigham Sep 22, 2020
@amcasey
Copy link
Member

amcasey commented Sep 22, 2020

I didn't update all the workflows when I added package-lock.json to old release branches - I just made the minimal change.

amcasey added a commit to amcasey/TypeScript that referenced this issue Sep 22, 2020
@amcasey
Backport package-lock infra changes to 4.0
a76f015 
From microsoft#40146
Fixes microsoft#40692
@amcasey amcasey mentioned this issue Sep 22, 2020
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Sep 22, 2020
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Sep 23, 2020
DanielRosenwasser pushed a commit that referenced this issue Jun 15, 2021
@amcasey
Backport package-lock infra changes to 3.9
4730bc2 
From #40146
From #40703
Fixes #40692

Also
@DanielRosenwasser DanielRosenwasser mentioned this issue Jun 15, 2021
Merged
DanielRosenwasser added a commit that referenced this issue Jun 16, 2021
@DanielRosenwasser @amcasey
Backport package-lock infra changes to 3.9 (#44608)
022bdea 
From #40146
From #40703
Fixes #40692

Also

Co-authored-by: Andrew Casey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcasey amcasey

Labels
Fix Available A PR has been opened for this issue Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
TypeScript 4.0.5
Development

No branches or pull requests
4 participants
@DanielRosenwasser @weswigham @amcasey @typescript-bot