Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Debug Failure. False expression. in 'ProjectService.applyChangesInOpenFiles' during 'updateOpen' #35034

Closed
typescript-bot opened this issue Nov 11, 2019 · 8 comments · Fixed by #37059
Closed

Error: Debug Failure. False expression. in 'ProjectService.applyChangesInOpenFiles' during 'updateOpen' #35034

typescript-bot opened this issue Nov 11, 2019 · 8 comments · Fixed by #37059
Assignees
@sheetalkamat
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Source: Telemetry The issue relates to the telemetry in editors VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone
Milestone
TypeScript 3.8.3

Comments

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 11, 2019 •
edited
Loading

This issue comes from crash dumps in telemetry. We've tried to de-duplicate issues on a best-effort basis, comparing the sequence of methods called and the command requested while ignoring line numbers.
TypeScript version prefix: 3.7.2
VSCode version: 1.40.0
Command requested: updateOpen
Hitting sessions: 999
Five line hash: 4d92d6402109da29bcae978b166e587c
Stack:

    at ProjectService.applyChangesInOpenFiles (tsserver.js:138343:34)
    at _a.<computed> (tsserver.js:139212:46)
    at <anonymous> (tsserver.js:140870:88)
    at Session.executeWithRequestId (tsserver.js:140861:28)
    at Session.executeCommand (tsserver.js:140870:33)
    at Session.onMessage (tsserver.js:140893:35)
    at <anonymous> (tsserver.js:142208:27)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
    at unknown (suppressed.js)
@typescript-bot typescript-bot added Bug A bug in TypeScript Source: Telemetry The issue relates to the telemetry in editors labels Nov 11, 2019
@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 3.7.3
VSCode version: 1.41.0-insider
Command requested: updateOpen
Hitting sessions: 383
Five line hash: ca3bd85aefb68326dd9676e80f0b27e5
Stack:

Error: Debug Failure. False expression: Script should not exist and not be open already
    at ProjectService.applyChangesInOpenFiles (tsserver.js:138377:34)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (tsserver.js:139259:46)
    at unknown (tsserver.js:140917:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:140908:28)
    at IOSession.Session.executeCommand (tsserver.js:140917:33)
    at IOSession.Session.onMessage (tsserver.js:140940:35)
    at Interface.<anonymous> (tsserver.js:142255:27)
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 3.7.4
VSCode version: 1.40.2
Command requested: updateOpen
Hitting sessions: 123
Five line hash: ca3bd85aefb68326dd9676e80f0b27e5
Stack:

Error: Debug Failure. False expression: Script should not exist and not be open already
    at ProjectService.applyChangesInOpenFiles (tsserver.js:138392:34)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (tsserver.js:139274:46)
    at unknown (tsserver.js:140932:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:140923:28)
    at IOSession.Session.executeCommand (tsserver.js:140932:33)
    at IOSession.Session.onMessage (tsserver.js:140955:35)
    at Interface.<anonymous> (tsserver.js:142270:27)
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 3.7.5
VSCode version: 1.41.1
Command requested: updateOpen
Hitting sessions: 175
Five line hash: ca3bd85aefb68326dd9676e80f0b27e5
Stack:

Error: Debug Failure. False expression.
    at ProjectService.applyChangesInOpenFiles (tsserver.js:138433:34)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (tsserver.js:139302:46)
    at unknown (tsserver.js:140960:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:140951:28)
    at IOSession.Session.executeCommand (tsserver.js:140960:33)
    at IOSession.Session.onMessage (tsserver.js:140983:35)
    at Interface.<anonymous> (tsserver.js:142298:27)
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()

@mjbvz mjbvz added the VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone label Feb 26, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Feb 26, 2020

@RyanCavanaugh Marking as VS Code priority since this is the second from the top hitter in TS 3.8.2

@mjbvz mjbvz mentioned this issue Feb 26, 2020
Closed
sheetalkamat added a commit that referenced this issue Feb 26, 2020
@sheetalkamat
Remove unnecessary assert (since we allow already open file to be ope…
724c755 
…ned again even through openFile command - partially) from updateOpen command

Fixes #35034
@sheetalkamat sheetalkamat mentioned this issue Feb 26, 2020
Merged
@sheetalkamat sheetalkamat added the Fix Available A PR has been opened for this issue label Feb 26, 2020
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this issue Feb 26, 2020
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#37059 into release-3.8
75dac2f 
Component commits:
724c755 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command Fixes microsoft#35034
sheetalkamat added a commit that referenced this issue Feb 26, 2020
@sheetalkamat
Remove unnecessary assert (since we allow already open file to be ope…
05c9ec3 
…ned again even through openFile command - partially) from updateOpen command (#37059)

Fixes #35034
sheetalkamat added a commit that referenced this issue Feb 26, 2020
@sheetalkamat
Cherry-pick PR #37059 into release-3.8 (#37060)
9bf6058 
Component commits:
724c755 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command Fixes #35034

Co-authored-by: Sheetal Nandi <[email protected]>
@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 3.8.3
VSCode version: 1.44.1
Command requested: updateOpen
Hitting sessions: 1656
Five line hash: ca3bd85aefb68326dd9676e80f0b27e5
Stack:

Error: Debug Failure. False expression.
    at ProjectService.applyChangesInOpenFiles (tsserver.js:143381:34)
    at Session.handlers.ts.createMapFromTemplate._a.<computed> (tsserver.js:144260:46)
    at unknown (tsserver.js:146003:88)
    at IOSession.Session.executeWithRequestId (tsserver.js:145994:28)
    at IOSession.Session.executeCommand (tsserver.js:146003:33)
    at IOSession.Session.onMessage (tsserver.js:146027:35)
    at Interface.<anonymous> (tsserver.js:147342:27)
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()
    at suppressed_frame()

@mjbvz mjbvz mentioned this issue Apr 20, 2020
Closed
@typescript-bot
Copy link
Collaborator Author

Revised stack format and updated hash.

@typescript-bot
Copy link
Collaborator Author

This issue reproduced in the following context:
TypeScript version prefix: 4.6.2
VSCode version: 1.65.0
Command requested: updateOpen
Hitting sessions: 422
Five line hash: 4d92d6402109da29bcae978b166e587c
Stack:

    at ProjectService.applyChangesInOpenFiles (tsserver.js:170934:34)
    at _a.<computed> (tsserver.js:172108:46)
    at <anonymous> (tsserver.js:174044:88)
    at Session.executeWithRequestId (tsserver.js:174035:28)
    at Session.executeCommand (tsserver.js:174044:33)
    at Session.onMessage (tsserver.js:174070:35)
    at <anonymous> (tsserver.js:176705:31)
    at unknown (suppressed.js:315:20)
    at unknown (suppressed.js:903:12)
    at unknown (suppressed.js:81:21)

@sheetalkamat
Copy link
Member

There is only one assert now https://github.com/microsoft/TypeScript/blob/main/src/server/editorServices.ts#L3722 and that seems reasonable.. If the file was not already present it seems incorrect protocol to use to apply changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheetalkamat sheetalkamat

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Source: Telemetry The issue relates to the telemetry in editors VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone
Projects
None yet
Milestone
TypeScript 3.8.3
Development

Successfully merging a pull request may close this issue.

Remove unnecessary assert microsoft/TypeScript
5 participants
@DanielRosenwasser @RyanCavanaugh @sheetalkamat @mjbvz @typescript-bot