Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark TSServer reponses affected by updateGraph calls #34774

Closed
DanielRosenwasser opened this issue Oct 28, 2019 · 1 comment · Fixed by #35675
Closed

Mark TSServer reponses affected by updateGraph calls #34774

DanielRosenwasser opened this issue Oct 28, 2019 · 1 comment · Fixed by #35675
Assignees
@amcasey
Labels
Domain: Performance Reports of unusually slow behavior Domain: TSServer Issues related to the TSServer Infrastructure Issue relates to TypeScript team infrastructure Suggestion An idea for TypeScript
Milestone
TypeScript 3.8.1

Comments

@DanielRosenwasser
Copy link
Member

TSServer logs currently get very noisy with updateGraph calls, but it's not clear what is actually the cause of the work being done there. From discussion with @amcasey, it sounds like a reasonable solution is to have TSServer responses should indicate that they're forcing updateGraph calls.
@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript Infrastructure Issue relates to TypeScript team infrastructure Domain: TSServer Issues related to the TSServer labels Oct 28, 2019
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.8.0 milestone Oct 28, 2019
@amcasey amcasey changed the title Mark whenever TSServer responses trigger an updateGraph Mark TSServer reponses affected by updateGraph calls Oct 28, 2019
@amcasey
Copy link
Member

amcasey commented Oct 28, 2019

The goal here is not to determine what triggers graph updates, but which operations are affected by updateGraph computations (i.e. delays), how often, and to what extent.

@DanielRosenwasser DanielRosenwasser mentioned this issue Nov 4, 2019
Closed
@amcasey amcasey added the Domain: Performance Reports of unusually slow behavior label Dec 6, 2019
amcasey added a commit to amcasey/TypeScript that referenced this issue Dec 13, 2019
@amcasey
Report time spent in updateGraph
06528cf 
Add a response property indicating how much of the elapsed time (from
`onMessage` to `doOutput`) was spent in `updateGraph` calls.  If there's
no `updateGraph` call, the property is undefined, to save space (with
the downside that it's harder to tell whether a given telemetry event
could have had the property).

Fixes microsoft#34774
@amcasey amcasey mentioned this issue Dec 13, 2019
Merged
amcasey added a commit that referenced this issue Jan 8, 2020
@amcasey
Report time spent in updateGraph (#35675)
071819b 
Add a response property indicating how much of the elapsed time (from
`onMessage` to `doOutput`) was spent in `updateGraph` calls.  If there's
no `updateGraph` call, the property is undefined, to save space (with
the downside that it's harder to tell whether a given telemetry event
could have had the property).

Fixes #34774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcasey amcasey

Labels
Domain: Performance Reports of unusually slow behavior Domain: TSServer Issues related to the TSServer Infrastructure Issue relates to TypeScript team infrastructure Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 3.8.1
Development

Successfully merging a pull request may close this issue.

Report time spent in updateGraph amcasey/TypeScript
3 participants
@DanielRosenwasser @RyanCavanaugh @amcasey