fix tests

microsoft · Sep 27, 2023 · ff025b3 · ff025b3
1 parent 54183fd
commit ff025b3
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 15 deletions.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -41191,7 +41191,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
             switch (node.kind) {
                 case SyntaxKind.ClassDeclaration:
                 case SyntaxKind.ClassExpression:
-                    if (checkUninitialized) {
+                    if (checkUnused) {
                         checkUnusedClassMembers(node, addDiagnostic);
                         checkUnusedTypeParameters(node, addDiagnostic);
                     }

diff --git a/tests/baselines/reference/unusedLocalsInMethod4.errors.txt b/tests/baselines/reference/unusedLocalsInMethod4.errors.txt
@@ -87,7 +87,7 @@ unusedLocalsInMethod4.ts(57,9): error TS2454: Variable 'x' is used before being
     }
 
     function f3() {
-        let x: number[];
+        let x: number[];    // should error
             ~
 !!! error TS2454: Variable 'x' is used before being assigned.
         function foo() {
@@ -97,7 +97,7 @@ unusedLocalsInMethod4.ts(57,9): error TS2454: Variable 'x' is used before being
     }
 
     function f4() {
-        let x: number;
+        let x: number;  // should error
             ~
 !!! error TS2454: Variable 'x' is used before being assigned.
         return {
@@ -107,7 +107,7 @@ unusedLocalsInMethod4.ts(57,9): error TS2454: Variable 'x' is used before being
         };
     }
 
-    declare let x: number;
+    declare let x: number;  // should error
     function f5() {
         x.toString();
     }

diff --git a/tests/baselines/reference/unusedLocalsInMethod4.js b/tests/baselines/reference/unusedLocalsInMethod4.js
@@ -49,23 +49,23 @@ function f2<T, NonNull extends {}>() {
 }
 
 function f3() {
-    let x: number[];
+    let x: number[];    // should error
     function foo() {
         x.toString();
     }
     foo();
 }
 
 function f4() {
-    let x: number;
+    let x: number;  // should error
     return {
         foo() {
             return x.toString();
         }
     };
 }
 
-declare let x: number;
+declare let x: number;  // should error
 function f5() {
     x.toString();
 }
@@ -120,14 +120,14 @@ function f2() {
     console.log(x9);
 }
 function f3() {
-    var x;
+    var x; // should error
     function foo() {
         x.toString();
     }
     foo();
 }
 function f4() {
-    var x;
+    var x; // should error
     return {
         foo: function () {
             return x.toString();

diff --git a/tests/baselines/reference/unusedLocalsInMethod4.symbols b/tests/baselines/reference/unusedLocalsInMethod4.symbols
@@ -188,7 +188,7 @@ function f2<T, NonNull extends {}>() {
 function f3() {
 >f3 : Symbol(f3, Decl(unusedLocalsInMethod4.ts, 45, 1))
 
-    let x: number[];
+    let x: number[];    // should error
 >x : Symbol(x, Decl(unusedLocalsInMethod4.ts, 48, 7))
 
     function foo() {
@@ -206,7 +206,7 @@ function f3() {
 function f4() {
 >f4 : Symbol(f4, Decl(unusedLocalsInMethod4.ts, 53, 1))
 
-    let x: number;
+    let x: number;  // should error
 >x : Symbol(x, Decl(unusedLocalsInMethod4.ts, 56, 7))
 
     return {
@@ -221,7 +221,7 @@ function f4() {
     };
 }
 
-declare let x: number;
+declare let x: number;  // should error
 >x : Symbol(x, Decl(unusedLocalsInMethod4.ts, 64, 11))
 
 function f5() {

diff --git a/tests/baselines/reference/unusedLocalsInMethod4.types b/tests/baselines/reference/unusedLocalsInMethod4.types
@@ -199,7 +199,7 @@ function f2<T, NonNull extends {}>() {
 function f3() {
 >f3 : () => void
 
-    let x: number[];
+    let x: number[];    // should error
 >x : number[]
 
     function foo() {
@@ -219,7 +219,7 @@ function f3() {
 function f4() {
 >f4 : () => { foo(): string; }
 
-    let x: number;
+    let x: number;  // should error
 >x : number
 
     return {
@@ -237,7 +237,7 @@ function f4() {
     };
 }
 
-declare let x: number;
+declare let x: number;  // should error
 >x : number
 
 function f5() {