Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds VFS deleteFile method #3173

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Conversation

marklundin
Copy link
Contributor

@marklundin marklundin commented Jul 3, 2024

This PR adds a deleteFile function to typescript/vfs which works alongside the createFile and updateFile methods.

A test for is this has also been included.

Fixes #2799

@marklundin
Copy link
Contributor Author

@marklundin please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment; this isn't a dev only change and requires a proper versions changset and description.

@marklundin marklundin requested a review from jakebailey July 8, 2024 19:08
@jakebailey jakebailey merged commit 725841a into microsoft:v2 Jul 8, 2024
8 checks passed
@typescript-bot typescript-bot mentioned this pull request Jul 8, 2024
@marklundin marklundin deleted the vfs-delete-file branch July 8, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing deleteFile function in VirtualTypeScriptEnvironment
3 participants