-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support implicit iterable interfaces #235
Conversation
bdbcbfe
to
9e34cb3
Compare
9e34cb3
to
c10db30
Compare
c10db30
to
605b247
Compare
TS.fsx
Outdated
@@ -1466,8 +1468,8 @@ module Emit = | |||
Pt.Reset() | |||
Pt.Printl "/////////////////////////////" | |||
match flavor with | |||
| Worker -> Pt.Printl "/// IE Worker APIs" | |||
| _ -> Pt.Printl "/// IE DOM APIs" | |||
| Worker -> Pt.Printl "/// MSEdge Worker APIs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would remove MSEdge
/ IE
alltogether.
@saschanaz we need to come up with a way to merge this with dom.iterable.d.ts in src/lib in the ts repo. |
[Symbol.iterator](): IterableIterator<ClientRect> | ||
} | ||
|
||
interface DOMStringList { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not seem itrable, https://www.w3.org/TR/DOM-Level-3-Core/core.html#DOMStringList
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It meets the standard on WHATWG spec:
interface DOMStringList {
readonly attribute unsigned long length;
getter DOMString? item(unsigned long index);
boolean contains(DOMString string);
};
It has 1. an indexed property getter and 2. an integer-typed attribute named “length”.
That file should ultimately be completely replaced by generated one, once we get #227 merged (as current input xml file does not have every needed data). I think we have two options, we can:
|
I'm not sure what happened on Travis side. |
new mono 5.0, not sure why.. |
This generates a new
dom.es6.generated.d.ts
which contains[Symbol.iterator]
index signature for some interfaces. ('es6' because it should ultimately supportsetlike
andmaplike
which will add some methods includingkeys()
values()
entries()
etc.)Copying from microsoft/TypeScript#5329: