Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping @saschanaz whenever Update core dependencies action fails #1282

Closed
saschanaz opened this issue Mar 2, 2022 · 11 comments · Fixed by #1310
Closed

Ping @saschanaz whenever Update core dependencies action fails #1282

saschanaz opened this issue Mar 2, 2022 · 11 comments · Fixed by #1310

Comments

@saschanaz
Copy link
Contributor

Something should ping me since I'm not the owner.
This was referenced Mar 2, 2022
Open
Merged
@saschanaz saschanaz changed the title Update core dependencies action is failing Ping @saschanaz whenever Update core dependencies action fails Mar 2, 2022
saschanaz added a commit to saschanaz/types-web that referenced this issue Apr 9, 2022
@saschanaz
Ping @saschanaz when update-core-deps fails
d27cae4 
Closes microsoft#1282.
@saschanaz saschanaz mentioned this issue Apr 9, 2022
Merged
sandersn pushed a commit that referenced this issue Apr 25, 2022
@saschanaz
Ping @saschanaz when update-core-deps fails (#1310)
8f84c99 
* Ping @saschanaz when update-core-deps fails

Closes #1282.

* Less specific way
@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

2 similar comments
@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

@saschanaz saschanaz mentioned this issue Aug 22, 2024
Merged
@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

@saschanaz saschanaz mentioned this issue Aug 30, 2024
Merged
@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

@saschanaz saschanaz mentioned this issue Oct 9, 2024
Merged
@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

@saschanaz saschanaz mentioned this issue Nov 6, 2024
Merged
@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

@sandersn
Copy link
Member

https://github.com/microsoft/TypeScript-DOM-lib-generator/actions/runs/11908769649/job/33184821427 shows that the error is "Unknown DOM type: GPUError":

Error: Unknown DOM type: GPUError
    at convertDomTypeToTsTypeSimple (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:322:[15](https://github.com/microsoft/TypeScript-DOM-lib-generator/actions/runs/11908769649/job/33184821427#step:9:16))
    at convertBaseType (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:266:24)
    at convertDomTypeToTsTypeWorker (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:278:22)
    at convertDomTypeToTsType (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:247:22)
    at Array.map (<anonymous>)
    at convertDomTypeToTsTypeWorker (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:280:14)
    at convertDomTypeToTsType (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:247:22)
    at convertDomTypeToTsReturnType (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:251:[22](https://github.com/microsoft/TypeScript-DOM-lib-generator/actions/runs/11908769649/job/33184821427#step:9:23))
    at emitSignature (file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:682:28)
    at file:///home/runner/work/TypeScript-DOM-lib-generator/TypeScript-DOM-lib-generator/lib/build/emitter.js:692:47

@sandersn
Copy link
Member

@saschanaz is the fix same as before, to manually update to the new version of bcd?

@saschanaz
Copy link
Contributor Author

saschanaz commented Nov 19, 2024 •
edited
Loading

No, the issue is that Safari did not add GPUError (they somehow hacked it with typedef) and thus per the support data GPUError has no two impl supports, and therefore the generator is freaking out with inconsistency. I fixed it locally (manually enabled GPUError for now) but I have to verify the huge WebGPU additions 😵‍💫

@saschanaz saschanaz mentioned this issue Nov 19, 2024
Merged
@typescript-bot
Copy link
Contributor

Hello contributors in this thread, kindly pinging y'all as the 'Update core dependencies' job failed today. Please fix it when you have time, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ping @saschanaz when update-core-deps fails saschanaz/types-web
3 participants
@sandersn @saschanaz @typescript-bot