Fix some children types might be overwritten during transforming to path rules #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moria97
commented
Mar 18, 2020
•
moria97
commented
- Fix some children types might be overwrited during transforming to path rules as shown in test cases.
- Change FHIR path matching logic to a standard interface supported by Hl7.FhirPath.
moria97
changed the title
BoyaWu10
reviewed
Mar 18, 2020
src/Fhir.Anonymizer.Core/AnonymizationConfigurations/ResourceAnonymizerContext.cs
Show resolved
Hide resolved
moria97
commented
Mar 18, 2020
| @@ -29,6 +29,7 @@ public void GivenATypeRule_WhenParseRule_TransformedPathRuleShouldBeReturned() | |||
|
|
|||
| Assert.Contains("Patient.address", context.PathSet); | |||
| Assert.Contains("Patient.name", context.PathSet); | |||
| Assert.Contains("Patient.name.period.start", context.PathSet); | |||
There was a problem hiding this comment.
This test case would not pass in master code as we treat all name nodes as the same structure and transform type rules based on Patient.name[0] but omits Patient.name[1].
BoyaWu10
approved these changes
Mar 20, 2020
deepak-ms
reviewed
Mar 20, 2020
| @@ -74,9 +74,7 @@ public ElementNode AnonymizeResourceNode(ElementNode root) | |||
| var resourceId = root.GetNodeId(); | |||
| foreach (var rule in resourceContext.RuleList) | |||
| { | |||
| var pathCompileExpression = new FhirPathCompiler().Compile($"{rule.Path}"); | |||
| var matchedNodes = pathCompileExpression(root, EvaluationContext.CreateDefault()) | |||
| .Cast<ElementNode>(); | |||
There was a problem hiding this comment.
Let me sync up with you on Teams to understand the details here.
deepak-ms
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.