Add customized anonymization processors #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiwjin
reviewed
Sep 16, 2021
DICOM/src/Microsoft.Health.Dicom.Anonymizer.Core/Processors/Factories/DicomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
qiwjin
reviewed
Sep 16, 2021
FHIR/src/Microsoft.Health.Fhir.Anonymizer.Shared.Core/AnonymizerEngine.cs
Outdated
Show resolved
Hide resolved
qiwjin
reviewed
Sep 16, 2021
DICOM/src/Microsoft.Health.Dicom.Anonymizer.Core/Processors/Factories/DicomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
moria97
reviewed
Sep 16, 2021
DICOM/src/Microsoft.Health.Dicom.Anonymizer.Core/Processors/Factories/DicomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
DICOM/src/Microsoft.Health.Dicom.Anonymizer.Core/Processors/Factories/DicomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
|
|
||
| public void Process(DicomDataset dicomDataset, DicomItem item, ProcessContext context) | ||
| { | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
Do we have a consistent error handling strategy for exceptions thrown from custom processors?
BoyaWu10
reviewed
Sep 16, 2021
DICOM/src/Microsoft.Health.Dicom.Anonymizer.Core/Processors/Factories/DicomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
DICOM/src/Microsoft.Health.Dicom.Anonymizer.Core/Processors/Factories/DicomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
FHIR/src/Microsoft.Health.Fhir.Anonymizer.Shared.Core/AnonymizerEngine.cs
Outdated
Show resolved
Hide resolved
BoyaWu10
reviewed
Sep 27, 2021
FHIR/src/Microsoft.Health.Fhir.Anonymizer.Shared.Core.UnitTests/AnonymizerEngineTests.cs
Outdated
Show resolved
Hide resolved
…nymization into personal/sowu/add-custom-processor
qiwjin
reviewed
Sep 28, 2021
DICOM/src/Microsoft.Health.Dicom.Anonymizer.Core/Processors/Factories/DicomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
FHIR/src/Microsoft.Health.Fhir.Anonymizer.Shared.Core/AnonymizerEngine.cs
Outdated
Show resolved
Hide resolved
BoyaWu10
reviewed
Oct 11, 2021
FHIR/src/Microsoft.Health.Fhir.Anonymizer.Shared.Core.UnitTests/AnonymizerEngineTests.cs
Outdated
Show resolved
Hide resolved
qiwjin
approved these changes
Oct 22, 2021
qiwjin
approved these changes
Oct 22, 2021
BoyaWu10
reviewed
Oct 25, 2021
...rc/Microsoft.Health.Fhir.Anonymizer.Shared.Core/Processors/Factory/CustomProcessorFactory.cs
Outdated
Show resolved
Hide resolved
BoyaWu10
approved these changes
Oct 25, 2021
sowu880
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.