Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new scripts, .zip with powershell scripts. Added SAP drop down … #76

Conversation

menakakmsft
Copy link
Collaborator

Added Validation PowerShell scripts along with the zipped file. Added layered on SAP Setup Assistant Drop Down Values managed .zip solution file for SAP Setup Assistant.

Copy link
Contributor

@Ryanb58 Ryanb58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments you might apply to multiple powershell scripts.

@menakakmsft menakakmsft self-assigned this Aug 21, 2024
Copy link
Contributor

@Ryanb58 Ryanb58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tshanep tshanep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - just need a final spelling fix in lines 3 & 6. "On-permises" should be "On-premises"

@menakakmsft menakakmsft merged commit 7719c33 into main Aug 22, 2024
4 checks passed
@Ryanb58 Ryanb58 deleted the users/menakakollu/sap-setup-assistant-scripts-and-layered-solution branch August 22, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants