Async methods should be named with the Async suffix

[ghost]

I've created a new project with the Windows Template Studio. However, the async methods aren't named like that. Async methods should always use the Async suffix wherever possible.

This is wrong:

public class FirstRunDisplayService
{
    internal static async Task ShowIfAppropriate()
    {
        ...
    }
}

This is the recommended way to go:

public class FirstRunDisplayService
{
    internal static async Task ShowIfAppropriateAsync()
    {
        ...
    }
}

[crutkas]

100% agree. We can do a hotfix on this.

[crutkas]

/cc @mrlacey

[mrlacey]

There are exceptions where a method shouldn't always have this suffix but it is a common convention.
Surprisingly not covered by our coding conventions.

moving to v1.3 milestone as 1.2 has shipped and I don't think this is worth a hotfix

[mrlacey]

Ok, @crutkas just seen you want this for a hotfix. changing it back.

[crutkas]

Lets hot fix, we already have one going out the door.

[crutkas]

this fix is now in production. Thanks @jlnostr for making us aware.