fix OPENROWSET with numeric codepage as string #69
Conversation
lBilali
requested review from
barbaravaldez,
dzsquared,
zijchen,
chlafreniere and
llali
as code owners
|
@microsoft-github-policy-service agree |
| if (vResult.OptionKind == BulkInsertOptionKind.CodePage) // Check for code page string constants | ||
| // Check for code page string constants. | ||
| // If codepage is int just use the value as is. Same as above when value is integerOrNumeric | ||
| if (vResult.OptionKind == BulkInsertOptionKind.CodePage && !int.TryParse(vValue.Value, out int value)) |
There was a problem hiding this comment.
the change seems correct but I'm wondering how the value is parsed as int if it's with single quotes. can you please verify with test that this work if the value is a CODEPAGE = '65001'
There was a problem hiding this comment.
I added a test case for CODEPAGE = '866' on the first commit but now I did one extra test case for CODEPAGE = '65001' as well
and both work
BTW I verifyed that it fails if there is a not number value other then 'ACP', 'OEM' and 'RAW' and it failes as expected.
NO test case added on that though
|
I'm still getting this in the latest version of VS. The OPENROWSET documentation clearly has single quotes around the value expected, making it look like it should expect a string |
|
You're right @jashwood, I'm also seeing an old version of scriptdom in VS. Checking with the team if the update can be picked into the next preview release. |
This pull request fixes #63
since when codepage is a number no check is done if the value is a valid codepage this change does the same when the code page is a number as string