Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross platform build #65

Merged
merged 31 commits into from
Jan 22, 2024
Merged

cross platform build #65

merged 31 commits into from
Jan 22, 2024

Conversation

dzsquared
Copy link
Contributor

@dzsquared dzsquared commented Jan 10, 2024 •
edited
Loading

goals:

  • enable cross-plat dotnet build
  • enable cross-plat P0 tests
  • add linux to build and P0 PR validation

dzsquared and others added 28 commits January 5, 2024 13:28
@dzsquared
ensuring tests use crlf line endings
d3fb2b7
@dzsquared
re-fixing line endings
2c7de27
@dzsquared
clearly don't know what I'm doing
3700597
@dzsquared
localizing gitattributes to test
05b7136
@dzsquared
reverting lineending change
3a7206f
@dzsquared
get rid of the gitattributes
f4ef49a
@dzsquared
cross plat build, no tests
4c395bb
@dzsquared
adding powershell
bf9ac2e
@dzsquared
correcting ast generator path
fa19adf
@dzsquared
build tools exes back on windows
9ac0bc4
@dzsquared
fixing windows build - always using netcore tools
b2c7344
@dzsquared
add linux build to PR validation
09aad2c
@dzsquared
workflow syntax correction
f441f82
@dzsquared
fixing linux pipeline error, probably
9340917
@dzsquared
correcting the case of astgen for linux
9010cd7
@dzsquared
starting P0 test support, down to 61 failures
5193fac
@zijchen
Normalize line endings in ParsingEntryPointsTests
c397b2d
@zijchen
Temporarily run PR check on all branches
895e18d
@zijchen
Update on pull_request
2af1b30
@dzsquared
standardizing scripts read from streamreader on CRLF
1c14bc5
@dzsquared
exempt scripts with specific line endings
5b7fac3
@dzsquared
finishing fixes to parsererrorstests.cs
eccb633
@dzsquared
Merge branch 'zijchen/xplat-build' of github.com:microsoft/SqlScriptD…
7dc785d 
…OM into drskwier/cross-platform-build
@dzsquared
down to 44 failures, parsingentrypointstests.cs done
a414f0e
@dzsquared
avoid gitattributes for line endings, again
3dea6b0
@dzsquared
fixing workloadclassifier test for windows
f8d55a6
@dzsquared
down to 8 failing P0
d1f9a04
@dzsquared
all P0 passing on linux
3d8a4c4
@dzsquared dzsquared marked this pull request as ready for review January 13, 2024 00:34
zijchen
zijchen reviewed Jan 13, 2024
View reviewed changes
.github/workflows/pr-validation.yml Outdated Show resolved Hide resolved
Test/Directory.Build.props Outdated Show resolved Hide resolved
zijchen
zijchen approved these changes Jan 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
Test/SqlDom/LexingEntryPointsTests.cs Outdated Show resolved Hide resolved
@dzsquared dzsquared merged commit c5d492d into main Jan 22, 2024
5 checks passed
@dzsquared dzsquared deleted the drskwier/cross-platform-build branch January 22, 2024 18:14
@DragonSWDev DragonSWDev mentioned this pull request Feb 29, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zijchen zijchen zijchen approved these changes

@llali llali llali approved these changes

@barbaravaldez barbaravaldez Awaiting requested review from barbaravaldez

@chlafreniere chlafreniere Awaiting requested review from chlafreniere chlafreniere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzsquared @zijchen @llali