Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids a slowdown on first-time NTT computation due to computing NTT objects upon first use (fixes HEXL slowing down some operations in Microsoft SEAL benchmarks intel/hexl#7, see also Initial Intel HEXL integration #312 (comment))
Also reduces the memory consumption: before this PR, the
ntt_cache_
was stored in each compilation unit separately due to using a static variable in the header file. Running./build/bin/sealbench
yields:[ 2590 MB] Total allocation from the memory pool
[ 2388 MB] Total allocation from the memory pool
Fixes the HEXL commit hash, which was mistakenly pointing to the
main
branch instead of the1.1.0
branch (see https://github.com/intel/hexl/tags).