Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why " j < i " not " j < size_ " ? #210

Closed
serendipity-crypto opened this issue Aug 30, 2020 · 1 comment
Closed

Why " j < i " not " j < size_ " ? #210

serendipity-crypto opened this issue Aug 30, 2020 · 1 comment

Comments

@serendipity-crypto
Copy link

image
Don’t all bases need to be judged in pairs ? (ignore my poor english)
@WeiDaiWD
Copy link
Contributor

Thanks for pointing this out. This is indeed a bug and skipped unit testing. Luckily this method is not currently used in SEAL library. It is fixed now and will be released soon. Please use RNSBase::extend(Modulus value) for now.

kimlaine pushed a commit that referenced this issue Sep 17, 2020
Fixed RNSBase::extend(const RNSBase &other), github issue #210.
b0f02d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WeiDaiWD @serendipity-crypto