Don't wrap _BaseParameter get and set

[jenshnielsen]

This breaks multi and array parameters because in unconditionally calls _save_val

Among other issues this resulted in a ~1Gb snapshot because all array parameters were suddenly stored in the snapshot

There are other solutions but I think it's fair not to wrap the getters and setters unconditionally

[nulinspiratie]

Isn't this why we have snapshot_value? If we would simply set snapshot_value to false by default for these parameters it should also solve the problem whilst still keeping the wrapped functionalities

…

On Wed, Oct 18, 2017, 7:50 PM Jens Hedegaard Nielsen < ***@***.***> wrote: This breaks multi and array parameters because in unconditionally calls _save_val Among other issues this resulted in a ~1Gb snapshot because all array parameters were suddenly stored in the snapshot There are other solutions but I think it's fair not to wrap the getters and setters unconditionally ------------------------------ You can view, comment on, or merge this pull request online at: #797 Commit Summary - Don't wrap _BaseParameter get and set File Changes - *M* qcodes/instrument/parameter.py <https://github.com/QCoDeS/Qcodes/pull/797/files#diff-0> (23) Patch Links: - https://github.com/QCoDeS/Qcodes/pull/797.patch - https://github.com/QCoDeS/Qcodes/pull/797.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#797>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGgLHTFK_5TvP26QTnr95uaVEvYqAd1sks5stbvIgaJpZM4P9Xei> .

[jenshnielsen]

I have implemented that as an alternative in #800

[WilliamHPNielsen]

We'll close this in favour of #800.