Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Rohde&Schwarz ZNLE VNA #6796

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Enable Rohde&Schwarz ZNLE VNA #6796

merged 10 commits into from
Jan 27, 2025

Conversation

FKMalina
Copy link
Contributor

This pull request includes minor changes to Rohde&Schwarz VNA driver, making it compatible with a family of the budget R&S VNA (ZNLE).

@FKMalina FKMalina requested a review from a team as a code owner January 15, 2025 12:43
@jenshnielsen
Copy link
Collaborator

@FKMalina Thanks for the contribution. Looks good. Please fix the small issues pointed out by the precommit hooks and my inline comment and then this should be good to merge

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.38%. Comparing base (120545f) to head (c1696fb).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/instrument_drivers/rohde_schwarz/ZNB.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6796   +/-   ##
=======================================
  Coverage   69.37%   69.38%           
=======================================
  Files         340      341    +1     
  Lines       31341    31355   +14     
=======================================
+ Hits        21744    21755   +11     
- Misses       9597     9600    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Jan 27, 2025
Merged via the queue into microsoft:main with commit 35aaf75 Jan 27, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants