Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lakeshore refactor #6128

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented May 28, 2024

  • Newsfragment

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 68.55346% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (6392f13) to head (6ecd5a0).
Report is 26 commits behind head on main.

Files Patch % Lines
...nstrument_drivers/Lakeshore/Lakeshore_model_325.py 1.96% 50 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6128      +/-   ##
==========================================
+ Coverage   67.47%   67.48%   +0.01%     
==========================================
  Files         352      352              
  Lines       31158    31257      +99     
==========================================
+ Hits        21023    21095      +72     
- Misses      10135    10162      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen marked this pull request as ready for review May 28, 2024 07:56
@jenshnielsen jenshnielsen requested a review from a team as a code owner May 28, 2024 07:56
@jenshnielsen jenshnielsen enabled auto-merge May 28, 2024 18:46
@jenshnielsen jenshnielsen added this pull request to the merge queue May 28, 2024
Merged via the queue into microsoft:main with commit 0ae6f4b May 28, 2024
20 checks passed
@jenshnielsen jenshnielsen deleted the lakeshore_refactor branch May 29, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants