Signal Hound closedevice command is broken by recent change

[AdriaanRol]

If you encounter a bug use the following template.

Steps to reproduce

1. Create a signal hound instrument
2. close the instrument

Expected behaviour

The instrument should close it's connection

Actual behaviour

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-179-10b60e3ec59a> in <module>()
----> 1 SH.closeDevice()

d:\githubrepos\qcodes\qcodes\instrument_drivers\signal_hound\USB_SA124B.py in closeDevice(self)
    168 
    169     def closeDevice(self):
--> 170         self.log.info('Closing Device with handle num: ',
    171                       self.deviceHandle.value)
    172 

d:\githubrepos\qcodes\qcodes\utils\helpers.py in __getattr__(self, key)
    304         raise AttributeError(
    305             "'{}' object and its delegates have no attribute '{}'".format(
--> 306                 self.__class__.__name__, key))
    307 
    308     def __dir__(self):

AttributeError: 'SignalHound_USB_SA124B' object and its delegates have no attribute 'log'

Bug is most likely related to a recent change where all instrument print statements were replaced with the self.log command. However self.log was not added to all instruments.

If this has since been fixed on the master I apologize for reporting.

System

Windows 7

ATS 9870-dev-branch

**** 48cf48

[eendebakpt]

Could this be related to #285? I added an exception for .name, but maybe we need more exceptions.

[giulioungaretti]

Uha, another case of why are there not static test for drivers. Hopefully fixable soon.

[jenshnielsen]

This is fixed by #1154