Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Cost LARGE] Configure Dependabot #8208

Closed
wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2020

Summary of the Pull Request

What is this about?

PR Checklist

  • Applies to Configure Dependabot #8204
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Configures Dependabot. Expect a huge amount of PRs after this PR merges. Make sure that you merge those PRs with care

Do not merge this PR until after atleast 0.27

Validation Steps Performed

How does someone test & validate?

See https://github.com/alannt777/PowerToys

@ghost ghost added Area-GitHub workflow Issues regarding the GitHub workflow and automation Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) labels Nov 24, 2020
@ghost
Copy link
Author

ghost commented Nov 24, 2020

This is going to be hard but it's important IMO

@ghost ghost changed the title [WIP] Configure Dependabot [WIP] [Cost LARGE] Configure Dependabot Nov 24, 2020
@github-actions
Copy link

New misspellings found, please review:

  • Dependabot
  • testapp
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"aae abkseg actionkeyword aeroglass alfredtheme APPDATA APPID appxpackage AProduct baf bakudies basedir bfa Bitmaps bretan BYCOMMAND calculatorpinyindb cbegin cend cheatsheet Combobox COUNTSLABELFMT ctx deletefilefolder Deserialized desktoppreviewhandler desktopshortcutinstalled dicts dirn dropdownstypekey dropdowntypekey DString Dvs EBF Ecma ecmascript ei eig eigval eigvec ENTIREITEMNAME evt excmd executionengine EXPLR ftp Fx fxml GETDESKWALLPAPER GWL gwoyeu hanyu hglobal hicon Highcontrast hyjiacan IAlphabet IExclusive iexplore IInstant IME IMulti Indexerpinyindb Inlining isborderless Italiano JObject jsonrpc KBHOOK KBM KListener KSeparator lastpos launcherpinyin Launcherpinyindb lbl lbx Linux LSHIFT MENUSTART nc NCol NHotkey numberbox orphanedkey osdetection Pampalona pdk PERSISTEDDATA pimpl pinyindb Pipename Plist plistlib pls Pluginpinyindb Polski Portugu POWERTOYNAME Prepends PREVPANE progman Programpinyindb Progressbar Rects reggedit remapkey remapkeyboard remapper remapshort Remoting reulst rgba rgn rk RPressed RStroked Rtc RWIN Scrollable scrollbar sessionending setings setwineventhook Shellpinyindb shortcutguide SHOWNA SHOWWINDOW Slovensk sni Srpski stefan strem stringstream subdir Subheader sublicensable superfancyzones SYSKEYDOWN systemcolors Tcp temppath thr Tls tmpnam tohex transaprency TRANSPARENTGRADIENT TResult TZone uac uapmanifestschema uk Unsubscribe USERPROFILE VGr VIRTUALDESKTOPCHANGE virtualized Virtualizing vkcode vstest Walkerpinyindb wangyiyun wca wcschr wcsrchr Webcam websearch wexfs winapi winlogo winr WINTAB WORKERW wsmatch wtmpnam Xecutor xyzpreviewhandler yinle yinyue yyy ZConfig "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"Actionkeyword appdata appid combobox Ctx Dependabot deserialized ebf Entireitemname explr fx gwl HGLOBAL HICON IEXPLORE ime jobject kbm lshift ncol pipename prevpane Progman Remapper Rgn rwin scrollable showwindow Subdir syskeydown testapp UAC unsubscribe userprofile Wca webcam WINAPI "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check || echo '... you want to ensure .github/actions/spell-check/expect.txt is added to your repository...'

@enricogior
Copy link
Contributor

Having to add each individual subfolder will require too much maintenance.
Possible solutions:

  • the yml file accepts wildcard (idea solution)
  • the yml is build automatically with a tool (not ideal but better than the current solution)

@ghost
Copy link
Author

ghost commented Nov 24, 2020

Having to add each individual subfolder will require too much maintenance.
Possible solutions:

  • the yml file accepts wildcard (idea solution)
  • the yml is build automatically with a tool (not ideal but better than the current solution)

I tried to do a wildcard in Launcher Plugins folder but I don't think it worked

Since its YAML, I think it is possible to create an automation system

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enricogior How about commenting out most of the config to have less PRs and slowly uncommenting each configuration?

@enricogior
Copy link
Contributor

Not sure what you mean.

@ghost
Copy link
Author

ghost commented Nov 24, 2020

Not sure what you mean.

Have only few project files monitored by @dependabot and slowly add more

@enricogior
Copy link
Contributor

Having to maintain that list manually is not acceptable, we don't want to have to deal with it every time we add or modify a project.

@ghost
Copy link
Author

ghost commented Nov 26, 2020

Closing this as there is no way to use wildcards or to write an automation system

@ghost ghost closed this Nov 26, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-GitHub workflow Issues regarding the GitHub workflow and automation Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant