Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hosts][EnvVar][RegPreview]improve nuget packages #32697

Merged
merged 16 commits into from
May 3, 2024

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

Improves the nuget structure for the abstracted utilities:

  • Add missing metadata to the packages.
  • Build for any CPU, so the nuget packages can be used for any architecture.
  • Remove the WinUIEx from the UI libraries, since it's unneeded. (It's only used by the app that consumes the libraries in our case).
  • Remove the xbf files, which are unneeded.
  • Release CI packs and signs the nuget packages.

PR Checklist

Validation Steps Performed

Built the nugetpackages in CI, and changed our apps to use the nuget packages instead of the project reference to the UILibs. Built local installer this way and verified the Hosts, RegPreview and EnvVars utility still work.

@jaimecbernardo
Copy link
Collaborator Author

Hi @DHowett ,
I've stolen this from Terminal for signing nuget packages: 4adde1e
LGTY? 😉

@jaimecbernardo jaimecbernardo marked this pull request as ready for review May 2, 2024 21:31
@jaimecbernardo
Copy link
Collaborator Author

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signing stuff looks right to me! Thanks!

@jaimecbernardo jaimecbernardo merged commit ee27bc8 into main May 3, 2024
15 checks passed
@crutkas crutkas deleted the dev/jaime/package-utils-nuget-for-release branch May 20, 2024 18:36
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.81 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants