Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] Tooltips fix and improvement #31361

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

davidegiacometti
Copy link
Collaborator

@davidegiacometti davidegiacometti commented Feb 8, 2024

Summary of the Pull Request

  • Fix tooltip closed automatically when opened with mouse more than 1 time
  • Improve spacing when tooltip text is wrapped
  • Don't use tab in tooltip for Registry plugin results (aligned to other plugins like WindowWalker)

PR Checklist

Detailed Description of the Pull Request / Additional comments

0.78.0 and PR comparison

2
2b

1
1b

Validation Steps Performed

  • Tested tooltips for Registry plugin results
  • Tested tooltips with long trimmed text (frequently happens with MSIX packages paths)
  • Tested tooltip opening more than 1 time for results
  • Tested tooltip opening more than 1 time for context actions
  • Tested context action tooltips with keyboard navigation

@davidegiacometti davidegiacometti marked this pull request as draft February 8, 2024 20:44
@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/run-tooltips branch from 2ea0cec to f737f37 Compare February 8, 2024 21:31
@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/run-tooltips branch from f737f37 to 7fdf744 Compare February 8, 2024 22:20
@davidegiacometti davidegiacometti marked this pull request as ready for review February 8, 2024 22:22
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 37867e0 into main Feb 16, 2024
14 checks passed
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/run-tooltips branch February 17, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants