[Run > Shell plugin] Shell selection improvements #28972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
htcfreek
changed the title
This comment has been minimized.
This comment has been minimized.
htcfreek
commented
Oct 3, 2023
@jaimecbernardo , @crutkas |
htcfreek
added
Idea-Enhancement
htcfreek
changed the title
|
How many have combo boxes |
One that I know. This feature was released with And it only brakes the ability to select an other value in settings ui. The plugin will still work and the setting won't change. |
This comment has been minimized.
This comment has been minimized.
|
@jaimecbernardo, @crutkas |
src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
src/modules/launcher/Plugins/Microsoft.Plugin.Shell/Properties/Resources.resx
Show resolved
Hide resolved
jaimecbernardo
requested changes
Oct 10, 2023
Co-authored-by: Jaime Bernardo <[email protected]>
Co-authored-by: Jaime Bernardo <[email protected]>
jaimecbernardo
approved these changes
Oct 11, 2023
|
@jaimecbernardo |
htcfreek
commented
Oct 11, 2023
src/settings-ui/Settings.UI/ViewModels/PluginAdditionalOptionViewModel.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
⚠ This PR breake existing third party plugins that have ComboBox options! ⚠ (For compatibility reason we could implement old and new code. But this means we have duplicated code.)
This PR improves the shell settings for the Shell plugin.
Changes in this PR:
The ComboBox items of a
PluginAdditionalOptionnow support reordering without braking existing user settings.PowerShell 7 has been added.
New settings to run CMD, PowerShell and PowerShell 7 in Windows Terminal as console host.
Various text improvements.
PR Checklist
pwsh.exe#28783Detailed Description of the Pull Request / Additional comments
Note: The name of the "Find and run executable file" item has changed after creating the screenshot.
Validation Steps Performed