Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run][Plugin Manager] Doc for 3rd party plugins #27566

Merged
merged 12 commits into from
Aug 8, 2023

Conversation

davidegiacometti
Copy link
Collaborator

@davidegiacometti davidegiacometti commented Jul 21, 2023

Summary of the Pull Request

I was wondering if we could make plugins created by the community more visible.

Chatted with @crutkas about creating a list of plugins and link to the repo and settings.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

image

image

Validation Steps Performed

@github-actions

This comment has been minimized.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@htcfreek
Copy link
Collaborator

@davidegiacometti
There are much more plugins. I suggest you to search for GitHub repos using the search term "PowerToys Run".

@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/run-plugins branch from 00c7889 to c568d2a Compare July 21, 2023 14:29
@davidegiacometti
Copy link
Collaborator Author

@davidegiacometti There are much more plugins. I suggest you to search for GitHub repos using the search term "PowerToys Run".

I drew up an initial list from #3200 and some GitHub tags.
The idea is to have this list maintained by creators and the community.

@@ -477,6 +484,9 @@
<controls:PageLink
x:Uid="LearnMore_Run"
Link="https://aka.ms/PowerToysOverview_PowerToysRun" />
<controls:PageLink
x:Uid="Run_FindMorePlugins"
Link="https://aka.ms/powerToysRunPlugins" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link needs to be created

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to direct it to https://github.com/microsoft/PowerToys/blob/main/doc/thirdPartyRunPlugins.md , which would be live after merging, is that right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaimecbernardo
Copy link
Collaborator

I knew there was this additional path, but didn't know 3rd party plugins were working out of the box :) TIL

Copy link
Contributor

@NathanD-GDS NathanD-GDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few docs suggestions to make them consistent with the Microsoft style guide.

doc/thirdPartyRunPlugins.md Outdated Show resolved Hide resolved
doc/thirdPartyRunPlugins.md Outdated Show resolved Hide resolved
doc/thirdPartyRunPlugins.md Outdated Show resolved Hide resolved
doc/thirdPartyRunPlugins.md Outdated Show resolved Hide resolved
doc/thirdPartyRunPlugins.md Outdated Show resolved Hide resolved
doc/thirdPartyRunPlugins.md Outdated Show resolved Hide resolved
@davidegiacometti
Copy link
Collaborator Author

@NathanD-GDS nice changes!
Thank you for the contribution! 😃

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution! Just missing some details on about the links and then we'll be good to go.

@jaimecbernardo jaimecbernardo merged commit 6425219 into main Aug 8, 2023
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/run-plugins branch August 9, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants