Build 2023 Configuration File for PowerToys #26259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@ryfu-msft it looks like you missed the "s" in ".configurations". |
fixing spelling
|
fixed spelling |
@denelon, where is that mistake? |
|
Yes, the convention is ".configurations/configuration.dsc.yaml" as the "default" configuration for a project. Putting the other configurations in the same directory allows for other versions of Visual Studio, and potentially other flavors of configurations. |
…erToys into buildConfiguration
I updated the folder name to be ".configurations" |
denelon
approved these changes
May 25, 2023
jaimecbernardo
approved these changes
May 29, 2023
BLM16
pushed a commit
to BLM16/PowerToys
that referenced
this pull request
Jun 22, 2023
* configuration * Update expect.txt fixing spelling * fix folder name --------- Co-authored-by: Clint Rutkas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
microsoft/winget-cli#2845