Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImageResizer]Fix silent context menu crash #22503

Merged

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

There's been a big number of crashes in Watson regarding ImageResizer context menu.
This PR adds some safeguards to try and reduce these.

Detailed Description of the Pull Request / Additional comments

Just some null checks and function success checks.

Validation Steps Performed

Couldn't reproduce the issue, so couldn't verify it locally.

Copy link
Contributor

@sosssego sosssego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jaimecbernardo jaimecbernardo merged commit d300b00 into microsoft:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants