Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerOCR][Telemetry]Cancel and capture events #20165

Merged

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

Adds telemetry events for when the OCR session is cancelled and when a capture occurs.

PR Checklist

  • Closes: Paste Text from Image #4371
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Adds telemetry events for when the OCR session is cancelled and when a capture occurs.

Validation Steps Performed

No validation for telemetry until we're out in the wild.

@Aaron-Junker
Copy link
Collaborator

Do we even use this telemtry data?

@jaimecbernardo
Copy link
Collaborator Author

Do we even use this telemtry data?

It's a way to check for feature popularity.

@jaimecbernardo jaimecbernardo merged commit 76ebed0 into microsoft:main Aug 31, 2022
@crutkas
Copy link
Member

crutkas commented Aug 31, 2022

yes, we use the data to validate are people using it as well as other things. We are an incubation team :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants