[PTRun][Calculator]Always accept decimal point #16980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyoyuppe
approved these changes
Mar 11, 2022
crutkas
approved these changes
Mar 11, 2022
1 task
26 tasks
htcfreek
added a commit
to htcfreek/PowerToys
that referenced
this pull request
May 22, 2022
jaimecbernardo
pushed a commit
that referenced
this pull request
Jun 2, 2022
* crash fixes and error result * small changes and test fixes * improve exceptions and message * double array crash fix * overflowexception * improve error handling * varous improvements * varous improvements * fix spelling * fix spelling * Revert #16980 * add description * error improvemenet * Update tests * spelling fixes * small changes * add settings * last changes * fix description * update dev docs * spell check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Users expect to be able to use decimal points
.in Calculator, even if their system is configured with another decimal separator character.Our translation of the user current locale into Mages numbers removes leading zeroes, leading to some calculation errors as can be seen in the linked issue.
What is included in the PR:
Accept
.as part of the number before translation, so that we don't end up removing leading zeroes from the decimal point of a number the user expects to work well.How does someone test / validate:
In a locale without
.as either the decimal serparator or number group separator, try to use numbers with.0in the decimal part and verify the calculation is correct.For example,
1.449*51.06should result in73.98594and not74.7684.Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.