Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings can not be opened after closing it while minimized from the taskbar #4430

Closed
arjunbalgovind opened this issue Jun 22, 2020 · 12 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Regression This was working in a previous release
Milestone

Comments

@arjunbalgovind
Copy link
Contributor

arjunbalgovind commented Jun 22, 2020

Environment

PowerToys version: 0.18.2

Steps to reproduce

  • Open PowerToys settings.

  • Minimize the settings window

  • Right click taskbar and close window
    image

  • Click PowerToys icon from systray

Expected behavior

Settings should open

Actual behavior

Nothing happens

@arjunbalgovind arjunbalgovind added Issue-Bug Something isn't working Product-Settings The standalone PowerToys Settings application Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jun 22, 2020
@ghost ghost added Status-In progress This issue or work-item is under development and removed Status-In progress This issue or work-item is under development labels Jun 25, 2020
@arjunbalgovind arjunbalgovind added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jun 25, 2020
@arjunbalgovind arjunbalgovind self-assigned this Jun 25, 2020
@arjunbalgovind arjunbalgovind added this to the InVEST-2006 milestone Jun 25, 2020
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 26, 2020
@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release

@crutkas crutkas closed this as completed Jun 30, 2020
@SSstar69
Copy link

SSstar69 commented Jul 7, 2020

build 0.19.0 on Windows 10, right-clicking PowerToys > Settings: still not opening.

@arjunbalgovind arjunbalgovind reopened this Jul 7, 2020
@arjunbalgovind arjunbalgovind added Severity-Regression This was working in a previous release and removed Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Jul 7, 2020
@arjunbalgovind arjunbalgovind removed their assignment Jul 7, 2020
@ghost ghost self-assigned this Jul 14, 2020
@ghost ghost added the Status-In progress This issue or work-item is under development label Jul 14, 2020
@ghost
Copy link

ghost commented Jul 14, 2020

This is fixed for me. @arjunbalgovind are you still able to repro it?

@arjunbalgovind
Copy link
Contributor Author

Yes, I can repro this on master.

@ghost
Copy link

ghost commented Jul 14, 2020

Yes, I can repro this on master.

okay thanks let me clone master.

@ryanbodrug-microsoft
Copy link
Contributor

@laviusmotileng-ms / @crutkas FYI: I've moved this to to 2008, and .21 as we are waiting on feedback, and this won't be done by EOD today.

@SSstar69
Copy link

SSstar69 commented Jul 26, 2020 via email

@saahmedm saahmedm added the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label Jul 30, 2020
@NN---
Copy link
Contributor

NN--- commented Aug 5, 2020

You don't need to lose focus.
Just go to other tab in settings.

@crutkas crutkas modified the milestones: InVEST-2008, InVEST-2009 Aug 28, 2020
@crutkas crutkas assigned ryanbodrug-microsoft and unassigned ghost Aug 28, 2020
@arjunbalgovind
Copy link
Contributor Author

@ryanbodrug-microsoft since this is related to the xaml islands hiding code, we could add back the Environment.Exit workaround that was done earlier in #4496. I don't think there is any negative effect of this.

@ryanbodrug-microsoft
Copy link
Contributor

ryanbodrug-microsoft commented Sep 1, 2020

Thanks @arjunbalgovind!

@arjunbalgovind
Copy link
Contributor Author

We can create a separate issue to remove that along with the xaml island hiding code when we move to WinUI 3.

@arjunbalgovind arjunbalgovind self-assigned this Sep 14, 2020
@arjunbalgovind arjunbalgovind added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Sep 16, 2020
@crutkas
Copy link
Member

crutkas commented Sep 30, 2020

Fixed in 0.23 of PowerToys. https://github.com/microsoft/PowerToys/releases/

@crutkas crutkas closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Regression This was working in a previous release
Projects
None yet
Development

No branches or pull requests

6 participants