Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.18.7 #380

Merged
merged 4 commits into from
Dec 12, 2021
Merged

Release 2.18.7 #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
978e0d8
Merged PR 215560: A few ESLint fixes
Nov 3, 2021
b57d332
Merged PR 217002: Refactor tests
Nov 18, 2021
c766b4a
Merged PR 194909: Add report getTheme API
aliabufoul Nov 21, 2021
5a90d7d
Merged PR 220053: Add background and wallpaper styles to report page …
aliabufoul Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
# Task 512388: Fix eslint warnings and errors in tests
test/*
/node_modules/*
demo/*
/**/*.js
dist/*
98 changes: 40 additions & 58 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,18 @@ module.exports = {
],
"rules": {
"@typescript-eslint/adjacent-overload-signatures": "warn",
"@typescript-eslint/array-type": [
"warn",
{
"default": "array-simple"
}
],
"@typescript-eslint/array-type": "off",
"@typescript-eslint/await-thenable": "warn",
"@typescript-eslint/ban-ts-comment": "warn",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/ban-types": [
"warn",
{
"types": {
"Object": {
"message": "Avoid using the `Object` type. Did you mean `object`?"
},
"Function": {
"message": "Avoid using the `Function` type. Prefer a specific function type, like `() => void`."
},
"Function": false,
"object": false,
"Boolean": {
"message": "Avoid using the `Boolean` type. Did you mean `boolean`?"
},
Expand All @@ -54,16 +48,18 @@ module.exports = {
}
}
],
"@typescript-eslint/consistent-type-assertions": "warn",
"@typescript-eslint/consistent-type-definitions": "warn",
"@typescript-eslint/dot-notation": "warn",
"@typescript-eslint/dot-notation": "off",
"@typescript-eslint/explicit-member-accessibility": [
"off",
{
"accessibility": "explicit"
}
],
"@typescript-eslint/explicit-module-boundary-types": "warn",
"@typescript-eslint/explicit-module-boundary-types": [
"warn",
{ "allowArgumentsExplicitlyTypedAsAny": true }
],
"@typescript-eslint/indent": [
"warn",
2,
Expand All @@ -90,6 +86,13 @@ module.exports = {
}
}
],
"@typescript-eslint/explicit-function-return-type": [
"error",
{
"allowExpressions": true,
"allowDirectConstAssertionInArrowFunctions": true
}
],
"@typescript-eslint/member-ordering": "off",
"@typescript-eslint/naming-convention": "off",
"@typescript-eslint/no-array-constructor": "warn",
Expand All @@ -98,29 +101,33 @@ module.exports = {
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-extra-non-null-assertion": "warn",
"@typescript-eslint/no-extra-semi": "warn",
"@typescript-eslint/no-floating-promises": "warn",
"@typescript-eslint/no-floating-promises": "off",
"@typescript-eslint/no-for-in-array": "warn",
"@typescript-eslint/no-implied-eval": "warn",
"@typescript-eslint/no-inferrable-types": "warn",
"@typescript-eslint/no-inferrable-types": "off",
"@typescript-eslint/no-misused-new": "warn",
"@typescript-eslint/no-misused-promises": "warn",
"@typescript-eslint/no-misused-promises": "off",
"@typescript-eslint/no-namespace": "warn",
"@typescript-eslint/no-non-null-asserted-optional-chain": "warn",
"@typescript-eslint/no-non-null-assertion": "warn",
"@typescript-eslint/no-parameter-properties": "off",
"@typescript-eslint/no-this-alias": "warn",
"@typescript-eslint/no-unnecessary-type-assertion": "warn",
"@typescript-eslint/no-unsafe-assignment": "warn",
"@typescript-eslint/no-unsafe-call": "warn",
"@typescript-eslint/no-unsafe-assignment": "off",
"@typescript-eslint/no-unsafe-call": "off",
"@typescript-eslint/no-unsafe-member-access": "off",
"@typescript-eslint/no-unsafe-return": "warn",
"@typescript-eslint/no-unsafe-return": "off",
"@typescript-eslint/no-unused-expressions": "warn",
"@typescript-eslint/no-unused-vars": "warn",
"@typescript-eslint/no-unused-vars": [
"warn",
{
"args": "after-used", "argsIgnorePattern": "^_"
}
],
"@typescript-eslint/no-use-before-define": "off",
"@typescript-eslint/no-var-requires": "warn",
"@typescript-eslint/prefer-as-const": "warn",
"@typescript-eslint/prefer-for-of": "warn",
"@typescript-eslint/prefer-function-type": "warn",
"@typescript-eslint/prefer-namespace-keyword": "warn",
"@typescript-eslint/prefer-regexp-exec": "off",
"@typescript-eslint/quotes": [
Expand All @@ -131,10 +138,9 @@ module.exports = {
],
"@typescript-eslint/require-await": "warn",
"@typescript-eslint/restrict-plus-operands": "warn",
"@typescript-eslint/restrict-template-expressions": "warn",
"@typescript-eslint/restrict-template-expressions": "off",
"@typescript-eslint/semi": [
"warn",
"always"
"error",
],
"@typescript-eslint/triple-slash-reference": [
"warn",
Expand All @@ -145,21 +151,16 @@ module.exports = {
}
],
"@typescript-eslint/type-annotation-spacing": "warn",
"@typescript-eslint/unbound-method": "warn",
"@typescript-eslint/unbound-method": "off",
"@typescript-eslint/unified-signatures": "warn",
"arrow-body-style": "warn",
"arrow-parens": [
"warn",
"always"
],
"arrow-parens": "off",
"brace-style": [
"off",
"1tbs"
],
"comma-dangle": "off",
"complexity": "off",
"constructor-super": "warn",
"curly": "warn",
"eol-last": "warn",
"eqeqeq": [
"warn",
Expand All @@ -178,7 +179,7 @@ module.exports = {
"Undefined",
],
"id-match": "warn",
"import/order": "warn",
"import/order": "off",
"jsdoc/check-alignment": "warn",
"jsdoc/check-indentation": "warn",
"jsdoc/newline-after-description": "warn",
Expand All @@ -189,7 +190,6 @@ module.exports = {
"max-len": "off",
"new-parens": "warn",
"no-array-constructor": "off",
"no-bitwise": "warn",
"no-caller": "warn",
"no-cond-assign": "warn",
"no-console": "off",
Expand All @@ -201,44 +201,26 @@ module.exports = {
"no-fallthrough": "off",
"no-implied-eval": "off",
"no-invalid-this": "off",
"no-multiple-empty-lines": "warn",
"no-multiple-empty-lines": ["error", { "max": 1 }],
"no-new-wrappers": "warn",
"no-shadow": [
"warn",
{
"hoist": "all"
}
],
"no-throw-literal": "warn",
"no-shadow": "off",
"no-trailing-spaces": "warn",
"no-undef-init": "warn",
"no-underscore-dangle": "warn",
"no-underscore-dangle": "off",
"no-unsafe-finally": "warn",
"no-unused-labels": "warn",
"no-unused-vars": "off",
"no-var": "warn",
"object-shorthand": ["warn", "never"],
"one-var": [
"warn",
"never"
],
"prefer-arrow/prefer-arrow-functions": "off",
"prefer-const": "warn",
"object-shorthand": "off",
"one-var": "off",
"prefer-const": "off",
"prefer-rest-params": "warn",
"quote-props": [
"warn",
"consistent-as-needed"
],
"radix": "warn",
"require-await": "off",
"space-before-function-paren": [
"warn",
{
"anonymous": "never",
"asyncArrow": "always",
"named": "never"
}
],
"space-before-function-paren": "off",
"spaced-comment": [
"warn",
"always",
Expand Down
28 changes: 25 additions & 3 deletions dist/powerbi-client.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// powerbi-client v2.18.6
// powerbi-client v2.18.7
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
declare module "config" {
Expand Down Expand Up @@ -780,7 +780,7 @@ declare module "visualDescriptor" {
}
declare module "page" {
import { IHttpPostMessageResponse } from 'http-post-message';
import { DisplayOption, FiltersOperations, ICustomPageSize, IFilter, IVisual, LayoutType, PageSizeType, SectionVisibility, VisualContainerDisplayMode } from 'powerbi-models';
import { DisplayOption, FiltersOperations, ICustomPageSize, IFilter, IVisual, LayoutType, PageSizeType, SectionVisibility, VisualContainerDisplayMode, IPageBackground, IPageWallpaper } from 'powerbi-models';
import { IFilterable } from "ifilterable";
import { IReportNode } from "report";
import { VisualDescriptor } from "visualDescriptor";
Expand Down Expand Up @@ -853,6 +853,18 @@ declare module "page" {
* @type {ICustomPageSize}
*/
defaultDisplayOption: DisplayOption;
/**
* Page background color.
*
* @type {IPageBackground}
*/
background: IPageBackground;
/**
* Page wallpaper color.
*
* @type {IPageWallpaper}
*/
wallpaper: IPageWallpaper;
/**
* Creates an instance of a Power BI report page.
*
Expand All @@ -863,7 +875,7 @@ declare module "page" {
* @param {SectionVisibility} [visibility]
* @hidden
*/
constructor(report: IReportNode, name: string, displayName?: string, isActivePage?: boolean, visibility?: SectionVisibility, defaultSize?: ICustomPageSize, defaultDisplayOption?: DisplayOption, mobileSize?: ICustomPageSize);
constructor(report: IReportNode, name: string, displayName?: string, isActivePage?: boolean, visibility?: SectionVisibility, defaultSize?: ICustomPageSize, defaultDisplayOption?: DisplayOption, mobileSize?: ICustomPageSize, background?: IPageBackground, wallpaper?: IPageWallpaper);
/**
* Gets all page level filters within the report.
*
Expand Down Expand Up @@ -1368,6 +1380,14 @@ declare module "report" {
* ```
*/
resetTheme(): Promise<void>;
/**
* get the theme of the report
*
* ```javascript
* report.getTheme();
* ```
*/
getTheme(): Promise<IReportTheme>;
/**
* Reset user's filters, slicers, and other data view changes to the default state of the report
*
Expand Down Expand Up @@ -1566,11 +1586,13 @@ declare module "report" {
private isMobileSettings;
/**
* Return the current zoom level of the report.
*
* @returns {Promise<number>}
*/
getZoom(): Promise<number>;
/**
* Sets the report's zoom level.
*
* @param zoomLevel zoom level to set
*/
setZoom(zoomLevel: number): Promise<void>;
Expand Down
Loading