Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v2.0.0-preview5 #2077

Merged
merged 134 commits into from
Jan 21, 2025
Merged

Release v2.0.0-preview5 #2077

merged 134 commits into from
Jan 21, 2025

Conversation

MaggieKimani1
Copy link
Contributor

No description provided.

baywet and others added 30 commits December 27, 2024 12:17
@baywet
fix: single copy and maintain for references
30ee6ed 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: uses backing fields instead of schema copy
6f4e7a2 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: linting
0a7b4f6 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat: adds components registration method for schemas
10e548a 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: linting
72db982 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
feat; adds a method to register and add the component schemas
efd2bfb 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: null propagation for most failed reference lookup
7994691 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: aligns missing properties for override
e3325b9 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: aligns to null propagation operator
8d57b81 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: updates public api file
b727581 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: linting
5b4c94e 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: linting
e366566 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: linting
a231748 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: side effects in tag references
878593b 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: potential NRT
9db6e2d 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: passes missing host document references to all layers
ff1406c
@dependabot
chore(deps): bump coverlet.collector from 6.0.2 to 6.0.3
1368eed 
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](coverlet-coverage/coverlet@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: coverlet.collector
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@baywet
Merge pull request #2034 from microsoft/dependabot/nuget/coverlet.col…
d5becc5 
…lector-6.0.3

chore(deps): bump coverlet.collector from 6.0.2 to 6.0.3
@dependabot
chore(deps): bump coverlet.msbuild from 6.0.2 to 6.0.3
df3744d 
Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 6.0.2 to 6.0.3.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](coverlet-coverage/coverlet@v6.0.2...v6.0.3)

---
updated-dependencies:
- dependency-name: coverlet.msbuild
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@baywet
Merge pull request #2035 from microsoft/dependabot/nuget/coverlet.msb…
4a0ef24 
…uild-6.0.3

chore(deps): bump coverlet.msbuild from 6.0.2 to 6.0.3
@baywet
fix: adds missing culture argument to date serialization
45329e4
@baywet
fix: uses the json node clone API to avoid unecessary allocs
818414d
@baywet
fix: date time and date time offset shifting zones
a6a44a7 
perf: avoid round trip serialization

Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: removes all obsolete APIs
e861c08
@baywet
chore: updates public api document
e478b75
@baywet
fix: removes useless condition for null check
4a50c77 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
Merge pull request #2037 from microsoft/fix/missing-culture
5de1bf2 
fix/missing culture
@baywet
Merge pull request #2040 from microsoft/chore/remove-obsolete
6655ded 
chore/remove obsolete
@baywet
Merge pull request #2039 from microsoft/fix/json-node-serialization
af55d61 
fix/json node serialization
@baywet
Merge pull request #2038 from microsoft/fix/clone-api
ffac64e 
fix/clone api
MaggieKimani1 and others added 19 commits January 16, 2025 19:52
@MaggieKimani1
Merge pull request #2063 from microsoft/mk/implement-AOT
b4f9c3e 
feat: configure AOT for trimming compatibility
@MaggieKimani1
Replicate copying logic for other component types
962e929
@dependabot
chore(deps): bump FluentAssertions from 7.0.0 to 7.1.0
dbf4d39 
Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 7.0.0 to 7.1.0.
- [Release notes](https://github.com/fluentassertions/fluentassertions/releases)
- [Changelog](https://github.com/fluentassertions/fluentassertions/blob/main/AcceptApiChanges.ps1)
- [Commits](fluentassertions/fluentassertions@7.0.0...7.1.0)

---
updated-dependencies:
- dependency-name: FluentAssertions
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@MaggieKimani1
Implement an interface for IOpenApiReferenceable items with a target …
7069446 
…object
@MaggieKimani1
Add reusable pathItems to components
32f75a1
@MaggieKimani1
Add test and update API surface
733185f
@baywet
Merge pull request #2070 from microsoft/dependabot/nuget/FluentAssert…
c87a3c2 
…ions-7.1.0

chore(deps): bump FluentAssertions from 7.0.0 to 7.1.0
@baywet
Merge branch 'dev' into fix/reference-copy
6e904d0
@dependabot
chore(deps): bump docker/build-push-action from 6.11.0 to 6.12.0
613a8e0 
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.11.0 to 6.12.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v6.11.0...v6.12.0)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
chore(deps): bump coverlet.msbuild from 6.0.3 to 6.0.4
e0f9763 
Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 6.0.3 to 6.0.4.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](coverlet-coverage/coverlet@v6.0.3...v6.0.4)

---
updated-dependencies:
- dependency-name: coverlet.msbuild
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@baywet
Merge pull request #2073 from microsoft/dependabot/nuget/coverlet.msb…
81c7474 
…uild-6.0.4

chore(deps): bump coverlet.msbuild from 6.0.3 to 6.0.4
@baywet
Merge pull request #2071 from microsoft/dependabot/github_actions/doc…
aa44c46 
…ker/build-push-action-6.12.0

chore(deps): bump docker/build-push-action from 6.11.0 to 6.12.0
@dependabot
chore(deps): bump coverlet.collector from 6.0.3 to 6.0.4
445b628 
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 6.0.3 to 6.0.4.
- [Release notes](https://github.com/coverlet-coverage/coverlet/releases)
- [Commits](coverlet-coverage/coverlet@v6.0.3...v6.0.4)

---
updated-dependencies:
- dependency-name: coverlet.collector
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@baywet
Merge pull request #2072 from microsoft/dependabot/nuget/coverlet.col…
b522f9f 
…lector-6.0.4

chore(deps): bump coverlet.collector from 6.0.3 to 6.0.4
@baywet
Merge pull request #2046 from microsoft/fix/reference-copy
995528e 
fix/reference copy
@MaggieKimani1
Bump preview versions
4a72387
@MaggieKimani1
Merge pull request #2074 from microsoft/chore/bump-preview-versions
8a83c6f 
Bump preview versions
@MaggieKimani1
pass host document for reference resolution
a3d0541
@MaggieKimani1
Add test
c39fa84
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
src/Microsoft.OpenApi/Models/OpenApiSecurityScheme.cs
@@ -82,10 +82,10 @@
/// </summary>
public OpenApiSecurityScheme(OpenApiSecurityScheme securityScheme)
{
Type = securityScheme?.Type ?? Type;
Type = securityScheme?.Type;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
src/Microsoft.OpenApi/Models/OpenApiSecurityScheme.cs
Description = securityScheme?.Description ?? Description;
Name = securityScheme?.Name ?? Name;
In = securityScheme?.In ?? In;
In = securityScheme?.In;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
src/Microsoft.OpenApi/Services/CopyReferences.cs
{
internal class CopyReferences : OpenApiVisitorBase
private readonly OpenApiDocument _target = target;
public OpenApiComponents Components = new();

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'Components' can be 'readonly'.
@MaggieKimani1
Merge pull request #2076 from microsoft/mk/fix-loading-error
9ccdd80 
Fix: Error validating OpenAPI using hidi preview
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
54.1% Coverage on New Code (required ≥ 80%)
5.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@baywet baywet merged commit 8943e2a into main Jan 21, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaggieKimani1 @baywet @mus65