Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/remove obsolete #2040

Merged
merged 25 commits into from
Jan 3, 2025
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9ff9789
Merge pull request #1846 from microsoft/vnext
MaggieKimani1 Sep 30, 2024
b5b11f5
Merge pull request #1860 from microsoft/vnext
irvinesunday Oct 4, 2024
97f8450
Merge pull request #1873 from microsoft/vnext
irvinesunday Oct 14, 2024
8c64b50
Merge pull request #1885 from microsoft/vnext
irvinesunday Oct 22, 2024
3e0a83f
Merge pull request #1898 from microsoft/vnext
irvinesunday Oct 29, 2024
18482f3
Merge pull request #1906 from microsoft/vnext
MaggieKimani1 Nov 6, 2024
d7b19ce
Merge pull request #1908 from microsoft/vnext
MaggieKimani1 Nov 7, 2024
df5d0c7
Merge pull request #1914 from microsoft/vnext
MaggieKimani1 Nov 12, 2024
55352f1
ci: updates main with the latest ci changes
baywet Dec 19, 2024
a3c6c83
fix: removes extraneous download artifact task
baywet Dec 19, 2024
662e9d7
fix: hidi GH release
baywet Dec 19, 2024
1ae06b1
fix: redundant artifact upload
baywet Dec 19, 2024
e521230
Merge pull request #2005 from microsoft/ci/updates-to-main
baywet Dec 19, 2024
166747f
fix: removes actions steps that create extraneous tags
baywet Dec 20, 2024
ff52d83
fix: updates output syntax for tag version
baywet Dec 20, 2024
2fcda79
ci: moves create github release to its own job
baywet Dec 20, 2024
ee99c4d
nit: fixes indent
baywet Dec 20, 2024
2efd4eb
Merge pull request #2017 from microsoft/fix/ci-hidi-gh-upload-to-main
baywet Dec 20, 2024
c3d0c15
Merge pull request #2015 from microsoft/dev
baywet Dec 20, 2024
e7dfa1a
fix: reverts to a regular variable for the tag value
baywet Dec 20, 2024
5a824bb
ci: fix artefacts path
baywet Dec 20, 2024
249ff45
Merge pull request #2021 from microsoft/fix/ci-tag-value-to-main
baywet Dec 20, 2024
cce2495
Merge pull request #2028 from microsoft/dev
baywet Dec 24, 2024
e861c08
fix: removes all obsolete APIs
baywet Jan 2, 2025
e478b75
chore: updates public api document
baywet Jan 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: removes extraneous download artifact task
Signed-off-by: Vincent Biret <[email protected]>
baywet committed Dec 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit a3c6c8330f26db5a181f17024a2b9e20ca8529f2
4 changes: 0 additions & 4 deletions .azure-pipelines/ci-build.yml
Original file line number Diff line number Diff line change
@@ -227,10 +227,6 @@ extends:
pool:
vmImage: ubuntu-latest
steps:
- task: DownloadPipelineArtifact@2
displayName: Download hidi executable from artifacts
inputs:
source: current
- pwsh: |
$artifactName = Get-ChildItem -Path $(Pipeline.Workspace)\Nugets -Filter Microsoft.OpenApi.*.nupkg -recurse | select -First 1
$artifactVersion= $artifactName.Name -replace "Microsoft.OpenApi.", "" -replace ".nupkg", ""

Unchanged files with check annotations Beta

writer.WriteStartObject();
// openApi;

Check warning on line 140 in src/Microsoft.OpenApi/Models/OpenApiDocument.cs

GitHub Actions / Build

Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
writer.WriteProperty(OpenApiConstants.OpenApi, "3.1.1");
// jsonSchemaDialect
/// Comparer for OpenApiSecurityScheme that only considers the Id in the Reference
/// (i.e. the string that will actually be displayed in the written document)
/// </summary>
private class OpenApiSecuritySchemeReferenceEqualityComparer : IEqualityComparer<OpenApiSecurityScheme>

Check warning on line 126 in src/Microsoft.OpenApi/Models/OpenApiSecurityRequirement.cs

GitHub Actions / Build

Private classes which are not derived in the current assembly should be marked as 'sealed'. (https://rules.sonarsource.com/csharp/RSPEC-3260)
{
/// <summary>
/// Determines whether the specified objects are equal.
public static OpenApiSecurityScheme LoadSecurityScheme(ParseNode node, OpenApiDocument hostDocument = null)
{
// Reset the local variables every time this method is called.
// TODO: Change _flow to a tempStorage variable to make the deserializer thread-safe.

Check warning on line 74 in src/Microsoft.OpenApi/Reader/V2/OpenApiSecuritySchemeDeserializer.cs

GitHub Actions / Build

Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
_flowValue = null;
_flow = new();
var currentScope = CurrentScope();
// If the object is empty, indicate it by writing { }

Check warning on line 75 in src/Microsoft.OpenApi/Writers/OpenApiYamlWriter.cs

GitHub Actions / Build

Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
if (previousScope.ObjectCount == 0)
{
// If we are in an object, write a white space preceding the braces.
namespace Microsoft.OpenApi
{
internal static class OpenAPIWriterExtensions

Check warning on line 5 in src/Microsoft.OpenApi/Extensions/OpenAPIWriterExtensions.cs

GitHub Actions / Build

Rename class 'OpenAPIWriterExtensions' to match pascal case naming rules, consider using 'OpenApiWriterExtensions'. (https://rules.sonarsource.com/csharp/RSPEC-101)
{
/// <summary>
/// Temporary extension method until we add Settings property to IOpenApiWriter in next major version
/// <summary>
/// Extension class for IList to add the Method "AddRange" used above
/// </summary>
public static class IDiagnosticExtensions

Check warning on line 56 in src/Microsoft.OpenApi/Reader/OpenApiDiagnostic.cs

GitHub Actions / Build

Move 'IDiagnosticExtensions' into a named namespace. (https://rules.sonarsource.com/csharp/RSPEC-3903)
{
/// <summary>
/// Extension method for IList so that another list can be added to the current list.
return schemaType switch
{
JsonSchemaType.Null => "null",
JsonSchemaType.Boolean => "boolean",

Check warning on line 26 in src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs

GitHub Actions / Build

Define a constant instead of using this literal 'boolean' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
JsonSchemaType.Integer => "integer",

Check warning on line 27 in src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs

GitHub Actions / Build

Define a constant instead of using this literal 'integer' 8 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
JsonSchemaType.Number => "number",

Check warning on line 28 in src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs

GitHub Actions / Build

Define a constant instead of using this literal 'number' 14 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
JsonSchemaType.String => "string",

Check warning on line 29 in src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs

GitHub Actions / Build

Define a constant instead of using this literal 'string' 13 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
JsonSchemaType.Array => "array",
JsonSchemaType.Object => "object",
_ => null,