-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <[email protected]>
fix: reverts to a regular variable for the tag value
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 28.6.1 to 28.7.0. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@28.6.1...28.7.0) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…-28.7.0 chore(deps): bump Verify.Xunit from 28.6.1 to 28.7.0
Signed-off-by: Vincent Biret <[email protected]>
fix: enum description number values
Comment on lines
+102
to
+105
if (value.GetValueKind() == JsonValueKind.Number) | ||
Value = value.GetValue<decimal>().ToString(CultureInfo.InvariantCulture); | ||
else | ||
Value = value.GetValue<string>(); |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.
feat: adds deconstructor to read result
fix: specifies encoding for net fx
chore: bumps preview version
baywet
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng,
MaggieKimani1 and
andrueastman
as code owners
December 24, 2024 14:22
darrelmiller
approved these changes
Dec 24, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting on