-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DataTypeMismatch validation rule from the default ruleset #1888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, do we want the rule completely removed from the code?
Or do we want the rule to not be in the default set of rules (meaning a caller of the library could opt in to it if they so wished)?
Oh actually yes, the intent is to remove it from the default ruleset and allow users to opt in. Let me correct that. |
This reverts commit 9bf3f08.
Quality Gate passedIssues Measures |
DataTypeMismatch
validation rule from the default ruleset by isolating it in a separate class to allow clients to opt in if need be.Fixes ValidateDataTypeMismatch is failing to parse examples #1879