Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle upcasting and downcasting of JSON schemas with type arrays #1820

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Handle upcasting and downcasting of JSON schemas with type arrays #1820

merged 7 commits into from
Oct 2, 2024

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1786

@gavinbarron gavinbarron linked an issue Sep 5, 2024 that may be closed by this pull request
Handle upcast and downcast of JSON Schemas with multiple types #1786
Closed
darrelmiller
darrelmiller requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you remove the code that removes the x-nullable this PR looks good.

darrelmiller
darrelmiller approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Although we should add a test case for when someone provides type as an array and also provides the nullable keyword. It should never happen but the current code would fail if it does.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MaggieKimani1 MaggieKimani1 merged commit f1c9297 into release/2.0.0 Oct 2, 2024
9 checks passed
@MaggieKimani1 MaggieKimani1 deleted the mk/handle-schemas-with-multiple-types branch October 2, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle upcast and downcast of JSON Schemas with multiple types
2 participants
@MaggieKimani1 @darrelmiller