Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiiuae/falcon-7b-instruct model support to llm-combined #907

Merged

Conversation

aamajumder
Copy link
Contributor

Describe your changes

Added the option to convert and run Falcon-7b-instruct using the llm.py script and the flag --model_type=falcon

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

@aamajumder aamajumder marked this pull request as draft January 29, 2024 19:27
@aamajumder
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@aamajumder aamajumder marked this pull request as ready for review January 29, 2024 22:11
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/user_script.py Fixed Show fixed Hide fixed
examples/directml/llm/llm.py Fixed Show fixed Hide fixed
examples/directml/llm/falcon.py Fixed Show fixed Hide fixed
@guotuofeng
Copy link
Collaborator

Please fix the lint errors.

@guotuofeng
Copy link
Collaborator

Please rebase from main.

@PatriceVignola
Copy link
Contributor

Please rebase from main.

This is going into a feature branch that is not up-to-date with the main branch yet because of all the churn. We'll rebase the feature branch before merging it into main.

@guotuofeng
Copy link
Collaborator

it seems there are some conflict?

examples/directml/llm/llm.py Fixed Show resolved Hide resolved
@PatriceVignola PatriceVignola merged commit f7dbe6d into microsoft:user/pavignol/llm-combined Feb 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants